From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/51] drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() Date: Mon, 9 Mar 2015 09:01:56 +0100 Message-ID: <20150309080156.GE24485@phenom.ffwll.local> References: <1423828140-10653-6-git-send-email-John.C.Harrison@Intel.com> <20150225221700.GE24485@phenom.ffwll.local> <20150226022651.GJ24485@phenom.ffwll.local> <54F854C2.7010208@Intel.com> <20150305144452.GF18775@phenom.ffwll.local> <54F87102.8020504@Intel.com> <20150305161400.GO18775@phenom.ffwll.local> <54F991C4.40804@Intel.com> <20150306155719.GT18775@phenom.ffwll.local> <54F9E6A2.3070803@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B3C16E14A for ; Mon, 9 Mar 2015 01:00:17 -0700 (PDT) Received: by wesw62 with SMTP id w62so9376544wes.0 for ; Mon, 09 Mar 2015 01:00:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <54F9E6A2.3070803@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMDYsIDIwMTUgYXQgMDU6NDA6NTBQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMDYvMDMvMTUgMTU6NTcsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBGcmks IE1hciAwNiwgMjAxNSBhdCAxMTozODo0NEFNICswMDAwLCBKb2huIEhhcnJpc29uIHdyb3RlOgo+ ID4+IE9uIDA1LzAzLzIwMTUgMTY6MTQsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4+IE9uIFRo dSwgTWFyIDA1LCAyMDE1IGF0IDAzOjA2OjQyUE0gKzAwMDAsIEpvaG4gSGFycmlzb24gd3JvdGU6 Cj4gPj4+PiBPbiAwNS8wMy8yMDE1IDE0OjQ0LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4+Pj4+ IEltbyByZXNlcnZpbmcgYSBiaXQgb2YgcmluZyBzcGFjZSBmb3IgZWFjaCBhZGRfcmVxdWVzdCBz aG91bGQgYmUgc29saWQuCj4gPj4+Pj4gVXNlcnNwYWNlIHVzZXMgdGhlIGV4YWN0IHNhbWUgcmVz ZXJ2YXRpb24gbG9naWMgZm9yIGFkZGluZyBlbmQtb2YtYmF0Y2gKPiA+Pj4+PiB3b3JrYXJvdW5k cy4gVGhlIG9ubHkgdGhpbmcgbmVlZGVkIHRvIG1ha2UgdGhpcyBzb2xpZCBpcyB0byBXQVJOIGlm Cj4gPj4+Pj4gYWRkX3JlcXVlc3QgZW5kcyB1cCB1c2luZyBtb3JlIHJpbmcgc3BhY2UgdGhhbiB3 aGF0IHdlJ3ZlIHJlc2VydmVkIChub3QKPiA+Pj4+PiBqdXN0IHdoZW4gaXQgYWN0dWFsbHkgcnVu cyBvdXQsIHRoYXQgb2J2aW91c2x5IGRvZXNuJ3QgaGFwcGVuIG9mdGVuCj4gPj4+Pj4gZW5vdWdo IGZvciB0ZXN0aW5nKS4KPiA+Pj4+IFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlcmUgY291bGQgYmUg bXVsdGlwbGUgcmVxdWVzdHMgYmVpbmcgcHJvY2Vzc2VkIGluCj4gPj4+PiBwYXJhbGxlbC4gVGhp cyBpcyBlc3BlY2lhbGx5IHRydWUgd2l0aCB0aGUgc2NoZWR1bGVyLiBVc2VybGFuZCBjb3VsZCBz dWJtaXQKPiA+Pj4+IGEgd2hvbGUgc3RyZWFtIG9mIGJhdGNoZXMgdGhhdCBhbGwgZ2V0IHF1ZXVl ZCB1cCBpbiB0aGUgc2NoZWR1bGVyLiBPbmx5Cj4gPj4+PiBsYXRlciBkbyB0aGV5IGdldCBzdWJt aXR0ZWQgdG8gdGhlIGhhcmR3YXJlLiBUaGUgcmVxdWVzdCBtdXN0IGJlIGFsbG9jYXRlZAo+ID4+ Pj4gdXAgZnJvbnQgYmVjYXVzZSB0aGVyZSBpcyBubyBvdGhlciBtZWFucyBvZiB0cmFja2luZyB0 aGVtLiBCdXQgcmVzZXJ2aW5nCj4gPj4+PiBzcGFjZSBhdCB0aGF0IHBvaW50IHdvbid0IHdvcmsg YmVjYXVzZSB5b3UgZWl0aGVyIGVuZCB1cCByZXNlcnZpbmcgbWFzc2l2ZQo+ID4+Pj4gYW1vdW50 cyBvZiBzcGFjZSBpZiB0aGUgcmVzZXJ2ZSBpcyBjdW11bGF0aXZlLCBvciBub3QgZW5vdWdoIGlm IG9ubHkgb25lCj4gPj4+PiBzbG90IGlzIHJlc2VydmVkLgo+ID4+PiBBdCBsZWFzdCB3aXRoIGV4 ZWNsaXN0IHdlIGRvbid0IGhhdmUgdGhhdCBwcm9ibGVtIHJlYWxseSBzaW5jZSB3cml0aW5nIHRo ZQo+ID4+PiByaW5nYnVmZmVyIGlzIGRvbmUgc3luY2hyb25vdXNseSBhbmQgZGlyZWN0bHkuCj4g Pj4+Cj4gPj4+IEZvciB0aGUgbGVnYWN5IHNjaGVkdWxlciBJIGV4cGVjdCB0aGF0IHdlIHdvbid0 IGRvIGFueSBvZiB0aGUgcmluZ2J1Zgo+ID4+PiB3cml0ZXMgZGlyZWN0bHkgYW5kIGluc3RlYWQg dGhhdCdzIGFsbCBkb25lIGJ5IHRoZSBzY2hlZHVsZXIKPiA+Pj4gYXN5bmNocm9ub3VzbHkuCj4g Pj4+Cj4gPj4+IFNvIHRoaXMgc2hvdWxkIGp1c3QgYmUgYW4gaXNzdWUgd2hpbGUgd2UgYXJlIGNv bnZlcnRpbmcgdG8gdGhlIHNjaGVkdWxlcgo+ID4+PiBvciBvbiBwbGF0Zm9ybXMgdGhhdCB3aWxs IG5ldmVyIGhhdmUgb25lLiBBbmQgaW1vIHRoZSByZXF1ZXN0IHJpbmdidWYKPiA+Pj4gcmVzZXJ2 YXRpb24gaXMgdGhlIHNvbHV0aW9uIHdpdGggdGhlIHNpbXBsZXN0IGltcGFjdCBvbiB0aGUgZGVz aWduLgo+ID4+IEkgZG9uJ3QgdW5kZXJzdGFuZCB3aGF0IHlvdSBtZWFuIGhlcmUuIFRoZSBzY2hl ZHVsZXIgZGVjb3VwbGVzIHRoZQo+ID4+IHN1Ym1pc3Npb24gb2YgYSBiYXRjaCBidWZmZXIgdG8g dGhlIGRyaXZlciB3aXRoIHRoZSBzdWJtaXNzaW9uIG9mIHRoYXQgYmF0Y2gKPiA+PiBidWZmZXIg dG8gdGhlIGhhcmR3YXJlLiBUaGUgc3VibWlzc2lvbiBjb2RlIHBhdGggaXRzZWxmIGlzIGlkZW50 aWNhbC4gVGhlCj4gPj4gc2NoZWR1bGVyIGRvZXMgbm90IGRvIGFueSBoYXJkd2FyZSB3cml0ZXMg LSBpdCBtZXJlbHkgYWRkcyBhbiBleHRyYSBsYXllcgo+ID4+IGJldHdlZW4gdGhlIHVzZXIgaW50 ZXJmYWNlIGNvZGUgYW5kIHRoZSBoYXJkd2FyZSBhY2Nlc3MgY29kZS4gVGhlIHJlcXVlc3QKPiA+ PiBjcmVhdGlvbiBtdXN0IGJlIGRvbmUgYXQgZHJpdmVyIHN1Ym1pc3Npb24gdGltZS4gVGhlIGhh cmR3YXJlIHN1Ym1pc3Npb24KPiA+PiBjb3VsZCBiZSBhbiBhcmJpdHJhcnkgYW1vdW50IG9mIHRp bWUgbGF0ZXIuIEluIHRoZSBpbnRlcnZlbmluZyB0aW1lLCBhbnkKPiA+PiBudW1iZXIgb2YgbmV3 IGJhdGNoIGJ1ZmZlcnMgbWF5IGJlIHN1Ym1pdHRlZCB0byB0aGUgZHJpdmVyIGFuZCB0aHVzIG5l dwo+ID4+IHJlcXVlc3RzIGJlIGNyZWF0ZWQuIFRoaXMgaXMgdHJ1ZSBmb3IgYm90aCBsZWdhY3kg YW5kIGV4ZWNsaXN0IG1vZGUuCj4gPj4KPiA+PiBUaGUgc3BhY2UgcmVzZXJ2ZSB3b3VsZCBoYXZl IHRvIGJlIGRvbmUgYXQgdGhlIHN0YXJ0IG9mIHRoZSBoYXJkd2FyZQo+ID4+IHN1Ym1pc3Npb24g cHJvY2VzcyBub3QgYXQgZHJpdmVyIHN1Ym1pc3Npb24gdGltZS4gSS5lLiBpdCB3b3VsZCBuZWVk IHRvIGJlIGEKPiA+PiBzZXBhcmF0ZSBhbmQgbmV3IGk5MTVfZ2VtX3JlcXVlc3RfcmVzZXJ2ZV9z cGFjZSgpIGNhbGwgYXQgdGhlIHN0YXJ0IG9mIHRoZQo+ID4+IGJhY2sgaGFsZiBvZiB0aGUgZXhl YyBidWZmZXIgY29kZS4gSXQgY291bGQgbm90IGJlIGRvbmUgZHVyaW5nIHJlcXVlc3QKPiA+PiBj cmVhdGlvbi4KPiA+IAo+ID4gWWVhaCB3aXRoIHRoZSBzY2hlZHVsZXIgd2UgbmVlZCB0byB0YWtl IG91dCB0aGUgcmVzZXJ2YXRpb24gYWdhaW4gc2luY2UgaXQKPiA+IGRvZXNuJ3QgbWFrZSBhIGxv dCBvZiBzZW5zZSAtIHRoZSBzY2hlZHVsZXIgaXMgdGhlIHNhZmV0eSBuZXQgdGhhdAo+ID4gZ3Vh cmFudGVlcyBleGVjdXRpb24gKGJhcnJpbmcgZ3B1IGRlYXRoIG9mYyBhcyBhbHdheXMpIHdoZW4g dGhlIGV4ZWNidWYKPiA+IGlvY3RsIHJldHVybnMgMC4gTWF5YmUgaW4gdGhlIGVuZCB3ZSBuZWVk IGEgc3BlY2lhbCBhbGxvY19yZXF1ZXN0IGZ1bmN0aW9uCj4gPiBmb3IgZXhlY2J1ZiB0byBvbmx5 IHJlc2VydmUgd2hlbiB0aGUgc2NoZWR1bGVyIGlzbid0IGFyb3VuZC4KPiA+IAo+ID4gVGhhdCBh ZGRpdGlvbmFsIHdvcmsgaXMganVzdCBwYXJ0IG9mIHRoZSBwcml6ZSB3ZSBoYXZlIHRvIHBheSB0 byBuZXZlcgo+ID4gYnJlYWsgdGhpbmdzIHdoaWxlIHJlZmFjdG9yaW5nIGNvZGUuIEFuZCBzaW5j ZSB3ZSdsbCBnZXQgdGhlIGV4ZWNsaXN0Cj4gPiBzY2hlZHVsZXIgaW4gZmlyc3QgdGhhdCByZXNl cnZhdGlvbiBjb2RlIHdpbGwgcHJvYmFibHkgc3RpY2sgYXJvdW5kIGZvciBhCj4gPiB3aGlsZSAo b3IgbWF5YmUgZm9yZXZlciBldmVuIGlmIHdlIGRlY2lkZSBhZ2FpbnN0IHVwc3RyZWFtaW5nIHRo ZSBnZW43Cj4gPiBzY2hlZHVsZXIpLgo+ID4gCj4gPiBEb2VzIHRoaXMgbWFrZSBzZW5zZT8KPiA+ IAo+ID4gVGhhbmtzLCBEYW5pZWwKPiAKPiBJIGFscmVhZHkgcHV0IGEgcHJlLXJlc2VydmF0aW9u IGluIHRoZSBwcmVlbXB0aXZlIHZlcnNpb24gb2YgdGhlCj4gc2NoZWR1bGVyLiBJdCB3b24ndCBz dGFydCB0byB3cml0ZSBhbnl0aGluZyBpbiB0aGUgcmluZ2J1ZmZlciB1bmxlc3MKPiBpdCdzIGd1 YXJhbnRlZWQgdGhlcmUncyBlbm91Z2ggc3BhY2UgdG8gd3JpdGUgdGhlIHdob2xlIHNldCBvZiBj b21tYW5kcwo+IHRvIHJ1biBhIGJhdGNoLCBmcm9tIHByZWFtYmxlIHRvIGZpbmFsaXNhdGlvbi4g VGhhdCBtZWFucyB0aGF0IG5vbmUgb2YKPiB0aGUgcmluZ19iZWdpbigpIGNvbW1hbmRzIGNhbiBm YWlsLCBhbmQgd2Ugd29uJ3QgbGVhdmUgYSBwYXJ0aWFsIHNldCBvZgo+IGNvbW1hbmRzIGluIHRo ZSByaW5nIHRvIGNvbmZ1c2UgYW55IHN1YnNlcXVlbnQgKHN1Y2Nlc3NmdWwpIHN1Ym1pc3Npb25z Lgo+IAo+IEFuZCB5ZXMsIEkgYWRkZWQgd2FybmluZ3MgaWYgdGhlIGNvbW1hbmRzIGVtaXR0ZWQg dG8gdGhlIHJpbmcgb3ZlcnJhbgo+IHRoZSBhbW91bnQgb2YgcmVzZXJ2ZWQgc3BhY2UsIHNvIHRo YXQgZGV2ZWxvcGVycyB3b3VsZCBrbm93IGlmIHRoZXknZAo+IGluY3JlYXNlZCB0aGUgdG90YWwg cmluZ3NwYWNlIHJlcXVpcmVtZW50Lgo+IAo+IElmIHRoZXJlIGFyZSBhbnkgb3RoZXIgZmFpbHVy ZSBtb2RlcyB3aGlsZSB3cml0aW5nIHRvIHRoZSByaW5nLCB3ZQo+IHNob3VsZCBzaW1wbHkgYmFj ayB1cCB0byB0aGUgc3RhcnQgb2YgdGhlIHNlcXVlbmNlIChpLmUuIHJld2luZCB0aGUKPiBzb2Z0 d2FyZSBjb3B5IG9mIFRBSUwgdG8gd2hlcmUgaXQgd2FzIGFmdGVyIHdlIGNoZWNrZWQgZm9yIHNw YWNlIC0tIGVhc3kKPiBiZWNhdXNlIHdlIGhhdmVuJ3QgdXBkYXRlZCBoL3cgVEFJTCB5ZXQpLCBh bmQgd2UgY2FuIGxlYXZlIHRoZSByZXF1ZXN0Cj4gcXVldWVkIGZvciBzdWJzZXF1ZW50IHJldHJ5 IChvciBmYWlsIGl0IGFzIHRob3VnaCBpdCBoYWQgYmVlbiBzdWJtaXR0ZWQKPiBhbmQgdGhlbiBr aWxsZWQgYnkgVERSLCBpZiB0aGUgZmFpbHVyZSBtb2RlIHN1Z2dlc3RzIGl0J3Mgbm90IHJldHJ5 YWJsZSkuCgpTb3VuZHMgZ29vZC4KCj4gW2FzaWRlXSBPbmUgdmVyc2lvbiBvZiB0aGlzIHdhcyBw b3N0ZWQgYXMKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2ludGVsLWdm eC8yMDE0LURlY2VtYmVyLzA1NzI0Ny5odG1sIGJ1dAo+IHRoYXQgcmUtdXNlZCBpbnRlbF9yaW5n X2JlZ2luKCkgYXMgYSByZXNlcnZlLXNwYWNlIGNhbGwsIHdoZXJlYXMgYW5vdGhlcgo+IHZlcnNp b24gaGFzIGEgc2VwYXJhdGUgbm9uYmxvY2tpbmcgZnVuY3Rpb24gaW50ZWxfcmluZ190ZXN0X3Nw YWNlKCkgZm9yCj4gcHJlY2hlY2tpbmcgYXZhaWxhYmxlIHNwYWNlIFsvYXNpZGVdCgpJIHByZWZl ciB0aGUgZXhwbGljaXQgcmVzZXJ2YXRpb24gb3ZlciBhbGxvd2luZyBuZXN0aW5nLiBBbGxvd2lu ZyBuZXN0aW5nCmdpdmVzIHVzIGEgbG90IG1vcmUgcm9wZSB0aGFuIHdlIG5lZWQgSSB0aGluaywg c28gbXVjaCByb29tIGZvciAiY3JlYXRpdmUKYWJ1c2UiIChpLmUuIHJlYWxseSBoYXJkIHRvIHVu ZGVyc3RhbmQgYnVncykuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK