From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUsfy-0005iQ-98 for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:04:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUsfv-0006s3-3L for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:04:34 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:60276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUsfu-0006ra-Ql for qemu-devel@nongnu.org; Mon, 09 Mar 2015 04:04:31 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Mar 2015 08:04:27 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 785DD1B0805F for ; Mon, 9 Mar 2015 08:04:45 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2984P2P9437488 for ; Mon, 9 Mar 2015 08:04:25 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2984P2U021988 for ; Mon, 9 Mar 2015 02:04:25 -0600 Date: Mon, 9 Mar 2015 09:04:22 +0100 From: Cornelia Huck Message-ID: <20150309090422.1c48658e.cornelia.huck@de.ibm.com> In-Reply-To: <1425886371.29447.2@smtp.corp.redhat.com> References: <1425534531-6305-1-git-send-email-jasowang@redhat.com> <1425534531-6305-9-git-send-email-jasowang@redhat.com> <20150306132855.4af24602.cornelia.huck@de.ibm.com> <1425886371.29447.2@smtp.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" On Mon, 09 Mar 2015 15:32:51 +0800 Jason Wang wrote: > > > On Fri, Mar 6, 2015 at 8:28 PM, Cornelia Huck > wrote: > > On Thu, 5 Mar 2015 13:48:45 +0800 > > Jason Wang wrote: > > > >> Instead of depending on a macro, switch to use a bus specific queue > >> limit. > >> > >> Cc: Anthony Liguori > >> Cc: Michael S. Tsirkin > >> Signed-off-by: Jason Wang > >> --- > >> hw/virtio/virtio-pci.c | 12 +++++++----- > >> include/hw/virtio/virtio.h | 1 - > >> 2 files changed, 7 insertions(+), 6 deletions(-) > >> > > > >> diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > >> index 04ad532..9a81edf 100644 > >> --- a/include/hw/virtio/virtio.h > >> +++ b/include/hw/virtio/virtio.hs > >> @@ -92,7 +92,6 @@ typedef struct VirtQueueElement > >> struct iovec out_sg[VIRTQUEUE_MAX_SIZE]; > >> } VirtQueueElement; > >> > >> -#define VIRTIO_PCI_QUEUE_MAX 64 > >> #define VIRTIO_CCW_QUEUE_MAX 64 > > > > This hunk makes me think that the ccw limit shouldn't have been added > > here :) > > Yes, fail to find a common header at first try. But looks like I can > move this in include/hw/s390x/s390_flic.h. > Hm, I'm not 100% sure about that. Maybe if we introduce a #gsi define there and have virtio-ccw inherit that as queue limit? Having a virtio limit in the flic header feels a bit odd.