From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbbCJIXZ (ORCPT ); Tue, 10 Mar 2015 04:23:25 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:33209 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbbCJIXX (ORCPT ); Tue, 10 Mar 2015 04:23:23 -0400 Date: Tue, 10 Mar 2015 09:23:18 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg KH Subject: Re: linux-next: build warning after merge of the tty tree Message-ID: <20150310082318.GH7525@pengutronix.de> References: <20150310162816.3301cff5@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150310162816.3301cff5@canb.auug.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg, On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote: > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/tty/serial/imx.c: In function 'imx_set_termios': > drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] > if (port->rs485.flags & SER_RS485_ENABLED) > ^ > > Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half > duplex rs485"). should I send a fixed commit or do you prefer an incremental change? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |