From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752362AbbCJJTM (ORCPT ); Tue, 10 Mar 2015 05:19:12 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55506 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbbCJJTG (ORCPT ); Tue, 10 Mar 2015 05:19:06 -0400 X-Sasl-enc: k68Dr5pYuN6lv3sizcOzzJRayJGBo8fm4IS9hesKjtZN 1425979146 Date: Tue, 10 Mar 2015 10:19:04 +0100 From: Greg KH To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build warning after merge of the tty tree Message-ID: <20150310091904.GB13728@kroah.com> References: <20150310162816.3301cff5@canb.auug.org.au> <20150310082318.GH7525@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150310082318.GH7525@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 09:23:18AM +0100, Uwe Kleine-König wrote: > Hello Greg, > > On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote: > > After merging the tty tree, today's linux-next build (arm > > multi_v7_defconfig) produced this warning: > > > > drivers/tty/serial/imx.c: In function 'imx_set_termios': > > drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] > > if (port->rs485.flags & SER_RS485_ENABLED) > > ^ > > > > Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half > > duplex rs485"). > should I send a fixed commit or do you prefer an incremental change? It's already in my tree, so I need an add-on patch. thanks, greg k-h