All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hao <haokexin@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: book3e_64: fix the align size for paca_struct
Date: Tue, 10 Mar 2015 20:21:47 +0800	[thread overview]
Message-ID: <20150310122147.GB8745@pek-khao-d1.corp.ad.wrs.com> (raw)
In-Reply-To: <1425886285.4636.241.camel@kernel.crashing.org>

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Mon, Mar 09, 2015 at 06:31:25PM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2015-03-09 at 09:13 +0800, Kevin Hao wrote:
> > On Sun, Mar 08, 2015 at 08:13:26PM +1100, Benjamin Herrenschmidt wrote:
> > > On Sat, 2015-03-07 at 19:14 +0800, Kevin Hao wrote:
> > > > All the cache line size of the current book3e 64bit SoCs are 64 bytes.
> > > > So we should use this size to align the member of paca_struct.
> > > > With this change we save 192 bytes. Also change it to __aligned(size)
> > > > since it is preferred over __attribute__((aligned(size))).
> > > 
> > > Why should we favor the book3e CPUs over the book3s ones ?
> > 
> > Why do you think so? This only change the align size of the paca_struct's
> > members which are private to book3e CPUs, and should not have any effect
> > to book3s ones. Did I miss something?
> 
> No, your explanation was lacking that important detail :-)

Sorry for the confusion, I will add this information in the commit log.

Thanks,
Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

      reply	other threads:[~2015-03-10 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 11:14 [PATCH] powerpc: book3e_64: fix the align size for paca_struct Kevin Hao
2015-03-08  9:13 ` Benjamin Herrenschmidt
2015-03-09  1:13   ` Kevin Hao
2015-03-09  7:31     ` Benjamin Herrenschmidt
2015-03-10 12:21       ` Kevin Hao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310122147.GB8745@pek-khao-d1.corp.ad.wrs.com \
    --to=haokexin@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.