From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbbCJOlF (ORCPT ); Tue, 10 Mar 2015 10:41:05 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:39644 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbbCJOlB (ORCPT ); Tue, 10 Mar 2015 10:41:01 -0400 Date: Tue, 10 Mar 2015 15:40:53 +0100 From: Sascha Hauer To: Kevin Hilman Cc: devicetree@vger.kernel.org, James Liao , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de, Matthias Brugger , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver Message-ID: <20150310144053.GH24885@pengutronix.de> References: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> <1425888603-25800-3-git-send-email-s.hauer@pengutronix.de> <7h61a94zy0.fsf@deeprootsystems.com> <20150310094142.GD24885@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150310094142.GD24885@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:37:26 up 1 day, 5:58, 52 users, load average: 1.53, 1.55, 1.06 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 10:41:42AM +0100, Sascha Hauer wrote: > > > + if (data->bus_prot_mask) { > > > + u32 mask = data->bus_prot_mask; > > > + struct regmap *infracfg = scp->infracfg; > > > + > > > + regmap_update_bits(infracfg, INFRA_TOPAXI_PROTECTEN, mask, 0); > > > + > > > + expired = jiffies + HZ; > > > + > > > + while (1) { > > > + u32 val; > > > + > > > + ret = regmap_read(infracfg, INFRA_TOPAXI_PROTECTSTA1, &val); > > > + if (ret) > > > + return ret; > > > + > > > + if (!(val & mask)) > > > + break; > > > + > > > + cpu_relax(); > > > + if (time_after(jiffies, expired)) > > > + return -EIO; > > > + } > > > + } > > > > This whole "Clear bus protection bits" part seems like it should be an > > API in the infracfg driver. > > Ok, can do. Since the infracfg driver (which is really a clk driver) currently is pending for inclusion I don't want to add more patches to it. I decided to drop the protection bits for now and come back to this once the infracfg driver is merged. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Tue, 10 Mar 2015 15:40:53 +0100 Subject: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver In-Reply-To: <20150310094142.GD24885@pengutronix.de> References: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> <1425888603-25800-3-git-send-email-s.hauer@pengutronix.de> <7h61a94zy0.fsf@deeprootsystems.com> <20150310094142.GD24885@pengutronix.de> Message-ID: <20150310144053.GH24885@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 10, 2015 at 10:41:42AM +0100, Sascha Hauer wrote: > > > + if (data->bus_prot_mask) { > > > + u32 mask = data->bus_prot_mask; > > > + struct regmap *infracfg = scp->infracfg; > > > + > > > + regmap_update_bits(infracfg, INFRA_TOPAXI_PROTECTEN, mask, 0); > > > + > > > + expired = jiffies + HZ; > > > + > > > + while (1) { > > > + u32 val; > > > + > > > + ret = regmap_read(infracfg, INFRA_TOPAXI_PROTECTSTA1, &val); > > > + if (ret) > > > + return ret; > > > + > > > + if (!(val & mask)) > > > + break; > > > + > > > + cpu_relax(); > > > + if (time_after(jiffies, expired)) > > > + return -EIO; > > > + } > > > + } > > > > This whole "Clear bus protection bits" part seems like it should be an > > API in the infracfg driver. > > Ok, can do. Since the infracfg driver (which is really a clk driver) currently is pending for inclusion I don't want to add more patches to it. I decided to drop the protection bits for now and come back to this once the infracfg driver is merged. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |