From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753837AbbCJVfH (ORCPT ); Tue, 10 Mar 2015 17:35:07 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43791 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753638AbbCJVfD (ORCPT ); Tue, 10 Mar 2015 17:35:03 -0400 Date: Tue, 10 Mar 2015 22:31:17 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Lee Jones , Samuel Ortiz , Mark Brown , Liam Girdwood , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v5 11/12] ARM: dts: sun6i: Add pinmux settings for mmc1 to dtsi Message-ID: <20150310213117.GG5085@lukather> References: <1425988764-23618-1-git-send-email-wens@csie.org> <1425988764-23618-12-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+Pu8h6CsJtbukPM9" Content-Disposition: inline In-Reply-To: <1425988764-23618-12-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+Pu8h6CsJtbukPM9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2015 at 07:59:22PM +0800, Chen-Yu Tsai wrote: > mmc1 is used to connect to the WiFi chip on the Hummingbird A31. >=20 > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a= 31.dtsi > index 92abea20b946..39d87a901b46 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -581,6 +581,14 @@ > allwinner,pull =3D ; > }; > =20 > + mmc1_pins_a: mmc1@0 { > + allwinner,pins =3D "PG0", "PG1", "PG2", "PG3", > + "PG4", "PG5"; > + allwinner,function =3D "mmc1"; > + allwinner,drive =3D <2>; > + allwinner,pull =3D <0>; You should use the defines here. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --+Pu8h6CsJtbukPM9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU/2KlAAoJEBx+YmzsjxAgyoMQALGlffY4CvM4PV46cUDBDuOu TT1jqCQUwdqIsiVzXcg3dgdJDJgOdzfMaWU2gGKndv6GPtoZU4zkgEOvXDjjNmnf xN9JGo9/ZJJqrNWUBHVzm/tPkuQX9Ormq4P0uTqZ++XsIISbV2UaDY3LTUNGULr2 K40wzClUEjFP+XDHGrowhzPVhSyUrXbX0YL0xhXbx1ps80HKcMgIDJsValO1WTo5 FjBDK4e+AtX3BMMfAnJ5m0iLx1vsFPiyfYZF5LyR9St9pdXznTUO7XCJpKj1kf9j BmakG1E5BglkmEwTyJ8uAnStKPacraAyHZhZ0gqJWKC08ohJ2hpJb6bZDIo+zjXL sVlhXyFTFapZsYpknCGmGJCygGloE7WYfYJmH+yVZkE92A/zR6UnMPD/JCYXSlCO QHdRLT0GdalNOSI97BzYju6IG3hsGNVfVmcPHlA4mUwNJiHqwa1hlSom+s2MwaZP n4dwbnq0FNmazAm7AIWuZM9ZsXqW87NG+PuBN9Dp63YjFNvVvg4rKw8ApT3Gh6UE vm5U66HJrhMkt3oGacvu2zM5u+AYb+CrRgudp+ftTS2MHQuSNGpseu/rNaOISXRY DuJHltho2pXqAtuIcin8uhQkRvmtBj0DwNn4oo/ppCSiDi09jfHgmqei+n9KzDKZ 6pZFcxytqmkj6l+byyz2 =+gyk -----END PGP SIGNATURE----- --+Pu8h6CsJtbukPM9-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v5 11/12] ARM: dts: sun6i: Add pinmux settings for mmc1 to dtsi Date: Tue, 10 Mar 2015 22:31:17 +0100 Message-ID: <20150310213117.GG5085@lukather> References: <1425988764-23618-1-git-send-email-wens@csie.org> <1425988764-23618-12-git-send-email-wens@csie.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+Pu8h6CsJtbukPM9" Return-path: Content-Disposition: inline In-Reply-To: <1425988764-23618-12-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chen-Yu Tsai Cc: Lee Jones , Samuel Ortiz , Mark Brown , Liam Girdwood , Kumar Gala , Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --+Pu8h6CsJtbukPM9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2015 at 07:59:22PM +0800, Chen-Yu Tsai wrote: > mmc1 is used to connect to the WiFi chip on the Hummingbird A31. >=20 > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a= 31.dtsi > index 92abea20b946..39d87a901b46 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -581,6 +581,14 @@ > allwinner,pull =3D ; > }; > =20 > + mmc1_pins_a: mmc1@0 { > + allwinner,pins =3D "PG0", "PG1", "PG2", "PG3", > + "PG4", "PG5"; > + allwinner,function =3D "mmc1"; > + allwinner,drive =3D <2>; > + allwinner,pull =3D <0>; You should use the defines here. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --+Pu8h6CsJtbukPM9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU/2KlAAoJEBx+YmzsjxAgyoMQALGlffY4CvM4PV46cUDBDuOu TT1jqCQUwdqIsiVzXcg3dgdJDJgOdzfMaWU2gGKndv6GPtoZU4zkgEOvXDjjNmnf xN9JGo9/ZJJqrNWUBHVzm/tPkuQX9Ormq4P0uTqZ++XsIISbV2UaDY3LTUNGULr2 K40wzClUEjFP+XDHGrowhzPVhSyUrXbX0YL0xhXbx1ps80HKcMgIDJsValO1WTo5 FjBDK4e+AtX3BMMfAnJ5m0iLx1vsFPiyfYZF5LyR9St9pdXznTUO7XCJpKj1kf9j BmakG1E5BglkmEwTyJ8uAnStKPacraAyHZhZ0gqJWKC08ohJ2hpJb6bZDIo+zjXL sVlhXyFTFapZsYpknCGmGJCygGloE7WYfYJmH+yVZkE92A/zR6UnMPD/JCYXSlCO QHdRLT0GdalNOSI97BzYju6IG3hsGNVfVmcPHlA4mUwNJiHqwa1hlSom+s2MwaZP n4dwbnq0FNmazAm7AIWuZM9ZsXqW87NG+PuBN9Dp63YjFNvVvg4rKw8ApT3Gh6UE vm5U66HJrhMkt3oGacvu2zM5u+AYb+CrRgudp+ftTS2MHQuSNGpseu/rNaOISXRY DuJHltho2pXqAtuIcin8uhQkRvmtBj0DwNn4oo/ppCSiDi09jfHgmqei+n9KzDKZ 6pZFcxytqmkj6l+byyz2 =+gyk -----END PGP SIGNATURE----- --+Pu8h6CsJtbukPM9-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 10 Mar 2015 22:31:17 +0100 Subject: [PATCH v5 11/12] ARM: dts: sun6i: Add pinmux settings for mmc1 to dtsi In-Reply-To: <1425988764-23618-12-git-send-email-wens@csie.org> References: <1425988764-23618-1-git-send-email-wens@csie.org> <1425988764-23618-12-git-send-email-wens@csie.org> Message-ID: <20150310213117.GG5085@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 10, 2015 at 07:59:22PM +0800, Chen-Yu Tsai wrote: > mmc1 is used to connect to the WiFi chip on the Hummingbird A31. > > Signed-off-by: Chen-Yu Tsai > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi > index 92abea20b946..39d87a901b46 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -581,6 +581,14 @@ > allwinner,pull = ; > }; > > + mmc1_pins_a: mmc1 at 0 { > + allwinner,pins = "PG0", "PG1", "PG2", "PG3", > + "PG4", "PG5"; > + allwinner,function = "mmc1"; > + allwinner,drive = <2>; > + allwinner,pull = <0>; You should use the defines here. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: