From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751138AbbCKFWi (ORCPT ); Wed, 11 Mar 2015 01:22:38 -0400 Received: from ftx-008-i775.relay.mailchannels.net ([50.61.143.75]:30110 "EHLO relay.mailchannels.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750707AbbCKFWf (ORCPT ); Wed, 11 Mar 2015 01:22:35 -0400 X-Greylist: delayed 4200 seconds by postgrey-1.27 at vger.kernel.org; Wed, 11 Mar 2015 01:22:34 EDT X-Sender-Id: duocircle|x-authuser|jac299792458 X-Sender-Id: duocircle|x-authuser|jac299792458 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|jac299792458 X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1426046748001:3604246767 X-MC-Ingress-Time: 1426046748001 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 72.84.113.125 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+tAw4eoYgAWLxeV2ljJT8CwSxmYCPnVcw= X-DKIM: OpenDKIM Filter v2.6.8 io 4E0B480529 Date: Wed, 11 Mar 2015 04:05:39 +0000 From: Jason Cooper To: Shawn Guo Cc: Stefan Agner , tglx@linutronix.de, mark.rutland@arm.com, marc.zyngier@arm.com, u.kleine-koenig@pengutronix.de, kernel@pengutronix.de, arnd@arndb.de, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, pebolle@tiscali.nl, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/3] ARM: dts: vf610: add Miscellaneous System Control Module (MSCM) Message-ID: <20150311040539.GD21998@io.lakedaemon.net> References: <1425249689-32354-1-git-send-email-stefan@agner.ch> <1425249689-32354-4-git-send-email-stefan@agner.ch> <20150311004812.GU20455@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150311004812.GU20455@dragon> User-Agent: Mutt/1.5.21 (2010-09-15) X-AuthUser: jac299792458 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 08:48:15AM +0800, Shawn Guo wrote: > On Sun, Mar 01, 2015 at 11:41:29PM +0100, Stefan Agner wrote: > > Add the Miscellaneous System Control Module (MSCM) to the base > > device tree for Vybrid SoC's. This module contains registers > > to get information of the individual and current (accessing) > > CPU. In a second block, there is an interrupt router, which > > handles the routing of the interrupts between the two CPU cores > > on VF6xx variants of the SoC. However, also on single core > > variants the interrupt router needs to be configured in order > > to receive interrupts on the CPU's interrupt controller. Almost > > all peripheral interrupts are routed through the router, hence > > the MSCM module is the default interrupt parent for this SoC. > > > > In a earlier commit the interrupt nodes were moved out of the > > peripheral nodes and specified in the CPU specific vf500.dtsi > > device tree. This allowed to use the base device tree vfxxx.dtsi > > also for a Cortex-M4 specific device tree, which uses different > > interrupt nodes due to the NVIC interrupt controller. However, > > since the interrupt parent for peripherals is the MSCM module > > independently which CPU the device tree is used for, we can move > > the interrupt nodes into the base device tree vfxxx.dtsi again. > > Depending on which CPU this base device tree will be used with, > > the correct parent interrupt controller has to be assigned to > > the MSCM-IR node (GIC or NVIC). The driver takes care of the > > parent interrupt controller specific needs (interrupt-cells). > > > > Acked-by: Marc Zyngier > > Signed-off-by: Stefan Agner > > Stefan, > > I guess this patch has a run-time dependency on the first two in the > series, right? Or put it another way, if I apply this single patch on > my branch, the dtb and kernel built from the same branch do not work > together, right? If so, we will need to either wait for the first two > hit mainline or pull Jason's irqchip/vybrid branch into my tree as > prerequisite (irqchip/vybrid needs to be stable). No problem, I'll only add patches on top of this if needed. no rebasing. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v6 3/3] ARM: dts: vf610: add Miscellaneous System Control Module (MSCM) Date: Wed, 11 Mar 2015 04:05:39 +0000 Message-ID: <20150311040539.GD21998@io.lakedaemon.net> References: <1425249689-32354-1-git-send-email-stefan@agner.ch> <1425249689-32354-4-git-send-email-stefan@agner.ch> <20150311004812.GU20455@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150311004812.GU20455@dragon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Shawn Guo Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pebolle@tiscali.nl, linux@arm.linux.org.uk, pawel.moll@arm.com, arnd@arndb.de, ijc+devicetree@hellion.org.uk, marc.zyngier@arm.com, galak@codeaurora.org, linux-kernel@vger.kernel.org, Stefan Agner , robh+dt@kernel.org, kernel@pengutronix.de, u.kleine-koenig@pengutronix.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Mar 11, 2015 at 08:48:15AM +0800, Shawn Guo wrote: > On Sun, Mar 01, 2015 at 11:41:29PM +0100, Stefan Agner wrote: > > Add the Miscellaneous System Control Module (MSCM) to the base > > device tree for Vybrid SoC's. This module contains registers > > to get information of the individual and current (accessing) > > CPU. In a second block, there is an interrupt router, which > > handles the routing of the interrupts between the two CPU cores > > on VF6xx variants of the SoC. However, also on single core > > variants the interrupt router needs to be configured in order > > to receive interrupts on the CPU's interrupt controller. Almost > > all peripheral interrupts are routed through the router, hence > > the MSCM module is the default interrupt parent for this SoC. > > > > In a earlier commit the interrupt nodes were moved out of the > > peripheral nodes and specified in the CPU specific vf500.dtsi > > device tree. This allowed to use the base device tree vfxxx.dtsi > > also for a Cortex-M4 specific device tree, which uses different > > interrupt nodes due to the NVIC interrupt controller. However, > > since the interrupt parent for peripherals is the MSCM module > > independently which CPU the device tree is used for, we can move > > the interrupt nodes into the base device tree vfxxx.dtsi again. > > Depending on which CPU this base device tree will be used with, > > the correct parent interrupt controller has to be assigned to > > the MSCM-IR node (GIC or NVIC). The driver takes care of the > > parent interrupt controller specific needs (interrupt-cells). > > > > Acked-by: Marc Zyngier > > Signed-off-by: Stefan Agner > > Stefan, > > I guess this patch has a run-time dependency on the first two in the > series, right? Or put it another way, if I apply this single patch on > my branch, the dtb and kernel built from the same branch do not work > together, right? If so, we will need to either wait for the first two > hit mainline or pull Jason's irqchip/vybrid branch into my tree as > prerequisite (irqchip/vybrid needs to be stable). No problem, I'll only add patches on top of this if needed. no rebasing. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Wed, 11 Mar 2015 04:05:39 +0000 Subject: [PATCH v6 3/3] ARM: dts: vf610: add Miscellaneous System Control Module (MSCM) In-Reply-To: <20150311004812.GU20455@dragon> References: <1425249689-32354-1-git-send-email-stefan@agner.ch> <1425249689-32354-4-git-send-email-stefan@agner.ch> <20150311004812.GU20455@dragon> Message-ID: <20150311040539.GD21998@io.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 11, 2015 at 08:48:15AM +0800, Shawn Guo wrote: > On Sun, Mar 01, 2015 at 11:41:29PM +0100, Stefan Agner wrote: > > Add the Miscellaneous System Control Module (MSCM) to the base > > device tree for Vybrid SoC's. This module contains registers > > to get information of the individual and current (accessing) > > CPU. In a second block, there is an interrupt router, which > > handles the routing of the interrupts between the two CPU cores > > on VF6xx variants of the SoC. However, also on single core > > variants the interrupt router needs to be configured in order > > to receive interrupts on the CPU's interrupt controller. Almost > > all peripheral interrupts are routed through the router, hence > > the MSCM module is the default interrupt parent for this SoC. > > > > In a earlier commit the interrupt nodes were moved out of the > > peripheral nodes and specified in the CPU specific vf500.dtsi > > device tree. This allowed to use the base device tree vfxxx.dtsi > > also for a Cortex-M4 specific device tree, which uses different > > interrupt nodes due to the NVIC interrupt controller. However, > > since the interrupt parent for peripherals is the MSCM module > > independently which CPU the device tree is used for, we can move > > the interrupt nodes into the base device tree vfxxx.dtsi again. > > Depending on which CPU this base device tree will be used with, > > the correct parent interrupt controller has to be assigned to > > the MSCM-IR node (GIC or NVIC). The driver takes care of the > > parent interrupt controller specific needs (interrupt-cells). > > > > Acked-by: Marc Zyngier > > Signed-off-by: Stefan Agner > > Stefan, > > I guess this patch has a run-time dependency on the first two in the > series, right? Or put it another way, if I apply this single patch on > my branch, the dtb and kernel built from the same branch do not work > together, right? If so, we will need to either wait for the first two > hit mainline or pull Jason's irqchip/vybrid branch into my tree as > prerequisite (irqchip/vybrid needs to be stable). No problem, I'll only add patches on top of this if needed. no rebasing. thx, Jason.