From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable Date: Wed, 11 Mar 2015 11:03:56 +0100 Message-ID: <20150311100356.GD3800@phenom.ffwll.local> References: <1425986129-15547-1-git-send-email-ville.syrjala@linux.intel.com> <1425986129-15547-5-git-send-email-ville.syrjala@linux.intel.com> <20150310170151.GH27526@intel.com> <20150310175713.GJ11371@intel.com> <20150311095229.GZ3800@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id DDC146E817 for ; Wed, 11 Mar 2015 03:02:16 -0700 (PDT) Received: by wggy19 with SMTP id y19so7987468wgg.2 for ; Wed, 11 Mar 2015 03:02:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150311095229.GZ3800@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMTEsIDIwMTUgYXQgMTA6NTI6MjlBTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwNzo1NzoxM1BNICswMjAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAxMDowMTo1MUFNIC0w NzAwLCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwMTox NToyNFBNICswMjAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+ID4g PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ ID4gPiA+IC1zdGF0aWMgdm9pZCBkaXNhYmxlX3BsYW5lX2ludGVybmFsKHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lKQo+ID4gPiA+ICtzdGF0aWMgdm9pZCBfaW50ZWxfY3J0Y19lbmFibGVfcGxhbmVz KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ID4gPiA+ICB7Cj4gPiA+ID4gLQlzdHJ1Y3QgaW50 ZWxfcGxhbmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOwo+ID4gPiA+IC0J c3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUgPQo+ID4gPiA+IC0JCXBsYW5lLT5mdW5jcy0+ YXRvbWljX2R1cGxpY2F0ZV9zdGF0ZShwbGFuZSk7Cj4gPiA+ID4gLQlzdHJ1Y3QgaW50ZWxfcGxh bmVfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ID4g PiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmJhc2UuZGV2Owo+ID4gPiA+ICsJ ZW51bSBwaXBlIHBpcGUgPSBjcnRjLT5waXBlOwo+ID4gPiA+ICsJc3RydWN0IGludGVsX3BsYW5l ICpwbGFuZTsKPiA+ID4gPiArCWNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgKmNy dGNfZnVuY3MgPQo+ID4gPiA+ICsJCWNydGMtPmJhc2UuaGVscGVyX3ByaXZhdGU7Cj4gPiA+ID4g IAo+ID4gPiA+IC0JaW50ZWxfc3RhdGUtPnZpc2libGUgPSBmYWxzZTsKPiA+ID4gPiAtCWludGVs X3BsYW5lLT5jb21taXRfcGxhbmUocGxhbmUsIGludGVsX3N0YXRlKTsKPiA+ID4gPiArCWZvcl9l YWNoX2ludGVsX3BsYW5lKGRldiwgcGxhbmUpIHsKPiA+ID4gPiArCQljb25zdCBzdHJ1Y3QgZHJt X3BsYW5lX2hlbHBlcl9mdW5jcyAqZnVuY3MgPQo+ID4gPiA+ICsJCQlwbGFuZS0+YmFzZS5oZWxw ZXJfcHJpdmF0ZTsKPiA+ID4gPiArCQlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnN0YXRlID0K PiA+ID4gPiArCQkJdG9faW50ZWxfcGxhbmVfc3RhdGUocGxhbmUtPmJhc2Uuc3RhdGUpOwo+ID4g PiA+ICAKPiA+ID4gPiAtCWludGVsX3BsYW5lX2Rlc3Ryb3lfc3RhdGUocGxhbmUsIHN0YXRlKTsK PiA+ID4gPiArCQlpZiAocGxhbmUtPnBpcGUgIT0gcGlwZSkKPiA+ID4gPiArCQkJY29udGludWU7 Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCWlmIChmdW5jcy0+YXRvbWljX2NoZWNrKCZwbGFuZS0+YmFz ZSwgJnN0YXRlLT5iYXNlKSkKPiA+ID4gCj4gPiA+IE1heWJlIGFkZCBhIFdBUk5fT04oKSBoZXJl PyAgSSdtIGFzc3VtaW5nIHRoYXQgdGhpcyBzaG91bGRuJ3QgcmVhbGx5IGJlCj4gPiA+IHBvc3Np YmxlIHNpbmNlIGlmIHRoaXMgZmFpbHMgaXQgbWVhbnMgd2UndmUgYWxyZWFkeSBwcmV2aW91c2x5 IGRvbmUgYQo+ID4gPiBjb21taXQgb2YgaW52YWxpZCBzdGF0ZSBvbiBhIHByZXZpb3VzIGF0b21p YyB0cmFuc2FjdGlvbi4gIEJ1dCBpZiBpdAo+ID4gPiBkb2VzIHNvbWVob3cgaGFwcGVuLCB0aGUg V0FSTiB3aWxsIGdpdmUgdXMgYSBjbHVlIHdoeSB0aGUgcGxhbmUgY29udGVudHMKPiA+ID4gc2lt cGx5IGRpZG4ndCBzaG93IHVwLgo+ID4gCj4gPiBJIGNhbiB0aGluayBvZiBvbmUgd2F5IHRvIG1h a2UgaXQgZmFpbC4gVGhhdCBpcywgZmlyc3Qgc2V0IGEgc21hbGxlcgo+ID4gbW9kZSB3aXRoIHRo ZSBwcmltYXJ5IHBsYW5lIChhbmQgZmIpIGNvbmZpZ3VyZWQgdG8gY292ZXIgdGhhdCBmdWxseSwg YW5kCj4gPiB0aGVuIHN3aXRjaCB0byBhIGxhcmdlciBtb2RlIHdpdGhvdXQgcmVjb25maWd1cmlu ZyB0aGUgcHJpbWFyeSBwbGFuZS4gSWYKPiA+IHRoZSBoYXJkd2FyZSByZXF1aXJlcyB0aGUgcHJp bWFyeSBwbGFuZSB0byBiZSBmdWxsc2NyZWVuIGl0J2xsIGZhaWwuIEJ1dAo+ID4gdGhhdCBzaG91 bGQgYWN0YXVsbHkgbm90IGJlIHBvc3NpYmxlIHVzaW5nIHRoZSBsZWdhY3kgbW9kZXNldCBBUEkg YXMgaXQKPiA+IGFsd2F5cyByZWNvbmZpZ3VyZXMgdGhlIHByaW1hcnksIHNvIHdlJ2Qgb25seSBo YXZlIHRvIHdvcnJ5IGFib3V0IHRoYXQKPiA+IHdpdGggZnVsbCBhdG9taWMgbW9kZXNldCwgYW5k IGZvciB0aGF0IHdlIGFueXdheSBuZWVkIHRvIGNoYW5nZSB0aGUgY29kZQo+ID4gdG8gZG8gdGhl IGNoZWNrIHN0dWZmIHVwIGZyb250Lgo+ID4gCj4gPiBTbyB5ZWFoLCB3aXRoIHRoZSB3YXkgdGhp bmdzIGFyZSB0aGlzIHNob3VsZCBub3QgYmUgYWJsZSB0byBmYWlsLiBJJ2xsCj4gPiByZXNwaW4g d2l0aCB0aGUgV0FSTi4KPiAKPiBJIGhhdmVuJ3QgZnVsbHkgZHVnIGludG8gdGhlIGRldGFpbHMg aGVyZSwgYnV0IGEgZmV3IHJhbmRvbWUgY29tbWVudHM6Cj4gLSBXaGlsZSB0cmFuc2l0aW9uaW5n IHdlJ3JlIGNhbGxpbmcgdGhlIHRyYW5zaXRpb25hbCBwbGFuZSBoZWxwZXJzLCB3aGljaAo+ICAg c2hvdWxkIGNhbGwgdGhlIGF0b21pY19jaGVjayBzdHVmZiBmb3IgdXMgb24gdGhlIHByaW1hcnkg cGxhbmUuIElmIHdlCj4gICBuZWVkIHRvIGNhbGwgYXRvbWljX2NoZWNrIG9uIG90aGVyIHBsYW5l cyB0b28gKHdoeT8pIHRoZW4gSSB0aGluayB0aGF0Cj4gICBzaG91bGQgYmUgZG9uZSBhcyBjbG9z ZSBhcyBwb3NzaWJsZSB0byB3aGVyZSB3ZSBkbyB0aGF0IGZvciB0aGUgcHJpbWFyeQo+ICAgb25l LiBTaW5jZSBldmVudHVhbGx5IHdlIG5lZWQgdG8gdW5idXJ5IHRoYXQgY2FsbCBhZ2Fpbi4KPiAK PiAtIEkgZG9uJ3QgbGlrZSBmcm9iYmluZyBzdGF0ZSBvYmplY3RzIHdoaWNoIGFyZSBjb21taXR0 ZWQgKGkuZS4gdXBkYXRpbmcKPiAgIHZpc2libGUgbGlrZSBoZXJlKSwgdGhleSdyZSBzdXBwb3Nl ZCB0byBiZSBpbnZhcmlhbnQuIFdpdGggcHJvcGVyIGF0b21pYwo+ICAgdGhlIHdheSB0byBkZWFs IHdpdGggdGhhdCBpcyB0byBncmFiIGFsbCB0aGUgcmVxdWlyZWQgcGxhbmUgc3RhdGVzIGFuZAo+ ICAgcHV0IHRoZW0gaW50byB0aGUgZHJtX2F0b21pY19zdGF0ZSB1cGRhdGUgc3RydWN0dXJlLgo+ IAo+IC0gTXkgaWRlYSBmb3IgcmVzb2x2aW5nIG91ciBjdXJyZW50IG5lc3RpbmcgaXNzdWVzIHdp dGgKPiAgIGVuYWJsZS9kaXNhYmxlX3BsYW5lcyBmdW5jdGlvbnMgd2FzIHR3byBwYXJ0czogYSkg b3Blbi1jb2RlIGEgaGFyZGNvZGVkCj4gICBkaXNhYmxlLWFsbC1wbGFuZXMgZnVuY3Rpb24gYnkg anVzdCBjYWxsaW5nIHBsYW5lIGRpc2FibGUgY29kZQo+ICAgdW5jb25kaXRpb25hbGx5LiBJaXJj IHRoZXJlJ3MgYmVlbiBwYXRjaGVzIG9uY2Ugc29tZXdoZXJlIHRvIGRvIHRoYXQKPiAgIHNwbGl0 IGluIGk5MTUgKG1heWJlIEknbSBkcmVhbWluZyksIGJ1dCB0aGlzIHVzZS1jYXNlIGlzIGFsc28g d2h5IEkKPiAgIGFkZGVkIHRoZSBhdG9taWNfcGxhbmVfZGlzYWJsZSBob29rLiBiKSBvbiByZXN0 b3JlIHdlIGp1c3QgZG8gYSBub3JtYWwKPiAgIHBsYW5lIGNvbW1pdCB3aXRoIHRoZSB1bmNoYW5n ZWQgcGxhbmUgc3RhdGVzLCB0aGV5IHNob3VsZCBhbGwgc3RpbGwKPiAgIHdvcmsuCj4gCj4gYnR3 IGlmIHdlIHdpcmUgdXAgdGhlIGF0b21pY19kaXNhYmxlX3BsYW5lIGhvb2sgdGhlbiB3ZSBjYW4g cmlwIG91dAo+IGludGVsX3BsYW5lX2F0b21pY191cGRhdGUuIFRoZSAiZG9uJ3QgZGlzYWJsZSB0 d2ljZSIgY2hlY2sgaXMgYWxyZWFkeSBkb25lCj4gYnkgdGhlIGhlbHBlcnMgaW4gdGhhdCBjYXNl Lgo+IAo+IEknbGwgZ3JhYiBzb21lIGNvZmZlZSBhbmQgc2VlIHdoYXQncyBhbGwgd3Jvbmcgd2l0 aCBteSBpZGVhcyBoZXJlIG5vdywgYnV0Cj4gcGxlYXNlIGJyaW5nIGluIGNyaXRpcXVlIHRvbyA7 LSkKCk9uZSBpbW1lZGlhdGUgcHJvYmxlbSBpcyB0aGF0IHdlIGtleSBvZmYgZnJvbSBpbnRlbF9z dGF0ZS0+dmlzaWJsZSB0bwpkZWNpZGUgd2hldGhlciB0byBlbmFibGUgb3Igbm90LCBhbmQgdGhl IGNvcmUgaGVscGVycyBrZXkgb2ZmIGZyb20Kc3RhdGUtPmZiLiBTbyBJIHRoaW5rIHdlJ2QgbmVl ZCB0byByb2xsIG91ciBvd24sIGJ1dCB3aXRoIHRoZSBzYW1lIGlkZWEKb2Ygc3BsaXR0aW5nIG91 dCBhbiBleHBsaWNpdCBwbGFuZV9kaXNhYmxlIGhvb2suCgpPciBtYXliZSB3ZSBzaG91bGQgYWRk IGEgZHJtX3BsYW5lX3N0YXRlLT52aXNpYmxlIGRlcml2ZWQgc3RhdGUgd2hpY2gKaGVscGVycyBm aWxsIG91dCB0byBtYXRjaCBkcm1fcGxhbmVfc3RhdGUtPmZiIGJ5IGRlZmF1bHQuIFRoYXQgbWln aHQgYmUKZXZlbiBuZWF0ZXIsIGFuZCBtYXRjaGVzIHNvbWV3aGF0IGhvdyB3ZSBhbGxvdyBkcml2 ZXJzIHRvIG92ZXJ3cml0ZQpjcnRjX3N0YXRlLT5uZWVkc19tb2Rlc2V0IHRvIGNvbnRyb2wgd2hp Y2ggaG9va3MgdGhlIGhlbHBlcnMgd2lsbCBjYWxsLgoKQ2xlYXJseSwgbW9yZSBjb2ZmZWUgaXMg bmVlZGUgaGVyZSA7LSkKLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=