From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/9] drm/i915: Make derived plane state correct after crtc_enable Date: Wed, 11 Mar 2015 11:24:34 +0100 Message-ID: <20150311102434.GH3800@phenom.ffwll.local> References: <1425986129-15547-1-git-send-email-ville.syrjala@linux.intel.com> <1425986129-15547-5-git-send-email-ville.syrjala@linux.intel.com> <20150310170151.GH27526@intel.com> <20150310175713.GJ11371@intel.com> <20150311095229.GZ3800@phenom.ffwll.local> <20150311100539.GO11371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id C1D186E81E for ; Wed, 11 Mar 2015 03:22:58 -0700 (PDT) Received: by widem10 with SMTP id em10so10354849wid.2 for ; Wed, 11 Mar 2015 03:22:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150311100539.GO11371@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMTEsIDIwMTUgYXQgMTI6MDU6MzlQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgTWFyIDExLCAyMDE1IGF0IDEwOjUyOjI5QU0gKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUdWUsIE1hciAxMCwgMjAxNSBhdCAwNzo1NzoxM1BNICsw MjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgTWFyIDEwLCAyMDE1IGF0 IDEwOjAxOjUxQU0gLTA3MDAsIE1hdHQgUm9wZXIgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBNYXIg MTAsIDIwMTUgYXQgMDE6MTU6MjRQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20gd3JvdGU6Cj4gPiA+ID4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gPiA+ID4gLXN0YXRpYyB2b2lkIGRpc2FibGVfcGxhbmVfaW50 ZXJuYWwoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4gPiA+ID4gPiArc3RhdGljIHZvaWQgX2lu dGVsX2NydGNfZW5hYmxlX3BsYW5lcyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiA+ID4gPiA+ ICB7Cj4gPiA+ID4gPiAtCXN0cnVjdCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUgPSB0b19pbnRl bF9wbGFuZShwbGFuZSk7Cj4gPiA+ID4gPiAtCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRl ID0KPiA+ID4gPiA+IC0JCXBsYW5lLT5mdW5jcy0+YXRvbWljX2R1cGxpY2F0ZV9zdGF0ZShwbGFu ZSk7Cj4gPiA+ID4gPiAtCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfc3RhdGUgPSB0 b19pbnRlbF9wbGFuZV9zdGF0ZShzdGF0ZSk7Cj4gPiA+ID4gPiArCXN0cnVjdCBkcm1fZGV2aWNl ICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiA+ID4gPiA+ICsJZW51bSBwaXBlIHBpcGUgPSBjcnRj LT5waXBlOwo+ID4gPiA+ID4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+ID4gPiA+ID4g Kwljb25zdCBzdHJ1Y3QgZHJtX2NydGNfaGVscGVyX2Z1bmNzICpjcnRjX2Z1bmNzID0KPiA+ID4g PiA+ICsJCWNydGMtPmJhc2UuaGVscGVyX3ByaXZhdGU7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAt CWludGVsX3N0YXRlLT52aXNpYmxlID0gZmFsc2U7Cj4gPiA+ID4gPiAtCWludGVsX3BsYW5lLT5j b21taXRfcGxhbmUocGxhbmUsIGludGVsX3N0YXRlKTsKPiA+ID4gPiA+ICsJZm9yX2VhY2hfaW50 ZWxfcGxhbmUoZGV2LCBwbGFuZSkgewo+ID4gPiA+ID4gKwkJY29uc3Qgc3RydWN0IGRybV9wbGFu ZV9oZWxwZXJfZnVuY3MgKmZ1bmNzID0KPiA+ID4gPiA+ICsJCQlwbGFuZS0+YmFzZS5oZWxwZXJf cHJpdmF0ZTsKPiA+ID4gPiA+ICsJCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqc3RhdGUgPQo+ ID4gPiA+ID4gKwkJCXRvX2ludGVsX3BsYW5lX3N0YXRlKHBsYW5lLT5iYXNlLnN0YXRlKTsKPiA+ ID4gPiA+ICAKPiA+ID4gPiA+IC0JaW50ZWxfcGxhbmVfZGVzdHJveV9zdGF0ZShwbGFuZSwgc3Rh dGUpOwo+ID4gPiA+ID4gKwkJaWYgKHBsYW5lLT5waXBlICE9IHBpcGUpCj4gPiA+ID4gPiArCQkJ Y29udGludWU7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCQlpZiAoZnVuY3MtPmF0b21pY19jaGVj aygmcGxhbmUtPmJhc2UsICZzdGF0ZS0+YmFzZSkpCj4gPiA+ID4gCj4gPiA+ID4gTWF5YmUgYWRk IGEgV0FSTl9PTigpIGhlcmU/ICBJJ20gYXNzdW1pbmcgdGhhdCB0aGlzIHNob3VsZG4ndCByZWFs bHkgYmUKPiA+ID4gPiBwb3NzaWJsZSBzaW5jZSBpZiB0aGlzIGZhaWxzIGl0IG1lYW5zIHdlJ3Zl IGFscmVhZHkgcHJldmlvdXNseSBkb25lIGEKPiA+ID4gPiBjb21taXQgb2YgaW52YWxpZCBzdGF0 ZSBvbiBhIHByZXZpb3VzIGF0b21pYyB0cmFuc2FjdGlvbi4gIEJ1dCBpZiBpdAo+ID4gPiA+IGRv ZXMgc29tZWhvdyBoYXBwZW4sIHRoZSBXQVJOIHdpbGwgZ2l2ZSB1cyBhIGNsdWUgd2h5IHRoZSBw bGFuZSBjb250ZW50cwo+ID4gPiA+IHNpbXBseSBkaWRuJ3Qgc2hvdyB1cC4KPiA+ID4gCj4gPiA+ IEkgY2FuIHRoaW5rIG9mIG9uZSB3YXkgdG8gbWFrZSBpdCBmYWlsLiBUaGF0IGlzLCBmaXJzdCBz ZXQgYSBzbWFsbGVyCj4gPiA+IG1vZGUgd2l0aCB0aGUgcHJpbWFyeSBwbGFuZSAoYW5kIGZiKSBj b25maWd1cmVkIHRvIGNvdmVyIHRoYXQgZnVsbHksIGFuZAo+ID4gPiB0aGVuIHN3aXRjaCB0byBh IGxhcmdlciBtb2RlIHdpdGhvdXQgcmVjb25maWd1cmluZyB0aGUgcHJpbWFyeSBwbGFuZS4gSWYK PiA+ID4gdGhlIGhhcmR3YXJlIHJlcXVpcmVzIHRoZSBwcmltYXJ5IHBsYW5lIHRvIGJlIGZ1bGxz Y3JlZW4gaXQnbGwgZmFpbC4gQnV0Cj4gPiA+IHRoYXQgc2hvdWxkIGFjdGF1bGx5IG5vdCBiZSBw b3NzaWJsZSB1c2luZyB0aGUgbGVnYWN5IG1vZGVzZXQgQVBJIGFzIGl0Cj4gPiA+IGFsd2F5cyBy ZWNvbmZpZ3VyZXMgdGhlIHByaW1hcnksIHNvIHdlJ2Qgb25seSBoYXZlIHRvIHdvcnJ5IGFib3V0 IHRoYXQKPiA+ID4gd2l0aCBmdWxsIGF0b21pYyBtb2Rlc2V0LCBhbmQgZm9yIHRoYXQgd2UgYW55 d2F5IG5lZWQgdG8gY2hhbmdlIHRoZSBjb2RlCj4gPiA+IHRvIGRvIHRoZSBjaGVjayBzdHVmZiB1 cCBmcm9udC4KPiA+ID4gCj4gPiA+IFNvIHllYWgsIHdpdGggdGhlIHdheSB0aGluZ3MgYXJlIHRo aXMgc2hvdWxkIG5vdCBiZSBhYmxlIHRvIGZhaWwuIEknbGwKPiA+ID4gcmVzcGluIHdpdGggdGhl IFdBUk4uCj4gPiAKPiA+IEkgaGF2ZW4ndCBmdWxseSBkdWcgaW50byB0aGUgZGV0YWlscyBoZXJl LCBidXQgYSBmZXcgcmFuZG9tZSBjb21tZW50czoKPiA+IC0gV2hpbGUgdHJhbnNpdGlvbmluZyB3 ZSdyZSBjYWxsaW5nIHRoZSB0cmFuc2l0aW9uYWwgcGxhbmUgaGVscGVycywgd2hpY2gKPiA+ICAg c2hvdWxkIGNhbGwgdGhlIGF0b21pY19jaGVjayBzdHVmZiBmb3IgdXMgb24gdGhlIHByaW1hcnkg cGxhbmUuIElmIHdlCj4gPiAgIG5lZWQgdG8gY2FsbCBhdG9taWNfY2hlY2sgb24gb3RoZXIgcGxh bmVzIHRvbyAod2h5PykKPiAKPiBCZWNhdXNlIHdlIHdhbnQgdGhlIGRlcml2ZWQgc3RhdGUgdG8g YmUgdXBkYXRlZCB0byBtYXRjaCB0aGUgKHBvdGVudGlhbGx5Cj4gY2hhbmdlZCkgY3J0YyBjb25m aWcuIFdlIGRvIGNhbGwgdGhlIC51cGRhdGVfcGxhbmUoKSBob29rIGZyb20gdGhlCj4gbW9kZXNl dCBwYXRoLCBidXQgdGhhdCBoYXBwZW5zIGF0IGEgdGltZSB3aGVuIHRoZSBwaXBlIGlzIG9mZiwg c28gb3VyCj4gY2xpcHBpbmcgY2FsY3VsYXRpb25zIGVuZCB1cCBzYXlpbmcgdGhlIHBsYW5lIGlz IGludmlzaWJsZS4gSSB0aGluayBmaXhpbmcKPiB0aGF0IHRoZSByaWdodCB3YXkgcHJldHR5IG11 Y2ggaW52b2x2ZXMgdGhlIGF0b21pYyBjb252ZXJzaW9uIG9mIHRoZQo+IG1vZGVzZXQgcGF0aC4K CldoeSBkbyB3ZSBjb25jbHVkZSBpdCdzIGludmlzaWJsZT8gSWYgd2UgY2FuIGZpeCB0aGUgc3Rh dGUgdG8gbm90IGRlcGVuZAp1cG9uIHRoZSBkcG1zIHN0YXRlIHRoZW4gdGhpbmdzIHNob3VsZCB3 b3JrIC4uLgoKPiA+ICAgdGhlbiBJIHRoaW5rIHRoYXQKPiA+ICAgc2hvdWxkIGJlIGRvbmUgYXMg Y2xvc2UgYXMgcG9zc2libGUgdG8gd2hlcmUgd2UgZG8gdGhhdCBmb3IgdGhlIHByaW1hcnkKPiA+ ICAgb25lLiBTaW5jZSBldmVudHVhbGx5IHdlIG5lZWQgdG8gdW5idXJ5IHRoYXQgY2FsbCBhZ2Fp bi4KPiAKPiBXaXRoIG15IHBhdGNoIF9hbGxfIHBsYW5lcyBnZXQgdGhlaXIgLmF0b21pY19jaGVj aygpIGNhbGxlZCBpbiB0aGUgc2FtZQo+IHBsYWNlIChkdXJpbmcgcGxhbmUgZW5hYmxlIHBoYXNl IG9mIC5jcnRjX2VuYWJsZSgpKS4KPiAKPiA+IAo+ID4gLSBJIGRvbid0IGxpa2UgZnJvYmJpbmcg c3RhdGUgb2JqZWN0cyB3aGljaCBhcmUgY29tbWl0dGVkIChpLmUuIHVwZGF0aW5nCj4gPiAgIHZp c2libGUgbGlrZSBoZXJlKSwgdGhleSdyZSBzdXBwb3NlZCB0byBiZSBpbnZhcmlhbnQuIFdpdGgg cHJvcGVyIGF0b21pYwo+ID4gICB0aGUgd2F5IHRvIGRlYWwgd2l0aCB0aGF0IGlzIHRvIGdyYWIg YWxsIHRoZSByZXF1aXJlZCBwbGFuZSBzdGF0ZXMgYW5kCj4gPiAgIHB1dCB0aGVtIGludG8gdGhl IGRybV9hdG9taWNfc3RhdGUgdXBkYXRlIHN0cnVjdHVyZS4KPiAKPiBXZSByZWFsbHkgd2FudCB0 byBmcm9iIGl0IHNvIHRoYXQgdGhlIGRlcml2ZWQgc3RhdGUgd2lsbCByZWZsZWN0Cj4gcmVhbGl0 eS4gTW9zdCBpbXBvcnRhbnRseSBzdGF0ZS0+dmlzaWJsZSBzaG91bGQgYmUgZmFsc2Ugd2hlbmV2 ZXIgdGhlCj4gcGlwZSBpcyBvZmYsIG90aGVyd2lzZSB3ZSBjYW4ndCB0cnVzdCBzdGF0ZS0+dmlz aWJsZSBhbmQgd291bGQgYWxzbyBuZWVkCj4gZ28gbG9vayBhdCB0aGUgY3J0YyBzdGF0ZSB3aGVu ZXZlciB3ZSdyZSB0cnlpbmcgdG8gZGVjaWRlIGlmIHRoZSBwbGFuZQo+IGlzIGFjdHVhbGx5IG9u IG9yIG5vdC4KCkltbyB0aGF0J3MgdGhlIGNvcnJlY3QgdGhpbmcgdG8gZG8uIENhbGxpbmcgcGxh bmUgaG9va3Mgd2hlbiB0aGUgcGlwZSBpcwpvZmYganVzdCBkb2Vzbid0IHNlZW0gbGlrZSBhIGdv b2QgaWRlYSB0byBtZS4gVG9nZXRoZXIgd2l0aCBydW50aW1lIHBtIGF0CmxlYXN0LCBjcnRjL2F0 b21pYyBoZWxwZXJzIGhhdmUgc29tZSAiaW50ZXJlc3RpbmciIGhlcml0YWdlLgoKQnV0IGV2ZW4g dGhlcmUgeW91IGNhbiBmaXggaXQgYnkganVzdCByZW9yZGVyaW5nIHRoZSBjb21taXRfcGxhbmVz IGNhbGwgdG8KdGhlIGJvdHRvbSwgd2hlcmUgZXZlcnl0aGluZyBzaG91bGQgYmUgb24uIElpcmMg dGhhdCdzIGhvdyBMYXVyZW50IGZpeGVkCnVwIHJjYXIgcnVudGltZSBwbSBpc3N1ZXMgdG8gYXZv aWQgdG91Y2hpbmcgcGxhbmVzIHdoZW4gdGhlIGh3IGlzIG9mZi4KClRoZSBvdGhlciByZWFzb24g d2h5IC0+dmlzaWJsZSBtdXN0IHRha2UgaW50byBhY2NvdW50IGRwbXMgc3RhdGUgaXMgdGhhdAp3 ZSdsbCBzY3JldyB1cCB0aGUgd2F0ZXJtYXJrIGNvbXB1dGF0aW9uIG90aGVyd2lzZS4gV2hpY2gg Y291bGQgcmVzdWx0CmludG8gYSBmYWlsdXJlIG9uIGEgc3Vic2VxdWVudCBkcG1zIG9uLCB3aGlj aCBpcyBhIGJpZyBuby1uby4KCj4gQXMgZm9yIHRoZSBkaXJlY3Qgc3RhdGUgZnJvYmJpbmcsIHdl IGNvdWxkIG1ha2UgYSBjb3B5IEkgZ3Vlc3MgYW5kIGZyb2IKPiB0aGF0IGluc3RlYWQsIGFuZCB0 aGVuIGNvbW1pdCBpdC4gQnV0IHRoYXQgc2VlbXMgYSBsb3Qgb2Ygd29yayBmb3Igbm8gZ2Fpbi4K ClRoYXQncyBob3cgYXRvbWljIGlzIHN1cHBvc2VkIHRvIHdvcmsgcmVhbGx5LiBCdXQgd2UgY2Fu J3QgbWFrZSBhIGNvcHkgaW4KdGhlIGNydGNfZW5hYmxlIHJlYWxseSBzaW5jZSB0aGF0IHNob3Vs ZCBuZXZlciBmYWlsLCBhbmQgd2UgY2FuJ3QgcHVzaCBpdApvdXQgc2luY2Ugd2UgbWlnaHQgbm90 IGhvbGQgYWxsIHRoZSBsb2Nrcy4gVGhhdCdzIGFsbCBvZmNvdXJzZSBmb3IgdGhlCmF0b21pYyBl bmQtc3RhdGUsIGJ1dCBJIHRoaW5rIGV2ZW4gYXMgYW4gaW50ZXJpbSBkZXRvdXIgdGhpcyBhcHBy b2FjaCBoZXJlCmRvZXNuJ3QgZmVlbCBsaWtlIGEgZ29vZCBhcHByb2FjaCB0byBtZS4KLURhbmll bAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K KzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=