From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 11 Mar 2015 10:40:32 -0400 Subject: [U-Boot] [PATCH] misc: led: Add PCA9551 LED driver In-Reply-To: <1426063900-7267-4-git-send-email-sr@denx.de> References: <1426063900-7267-1-git-send-email-sr@denx.de> <1426063900-7267-4-git-send-email-sr@denx.de> Message-ID: <20150311144032.GO32541@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Mar 11, 2015 at 09:51:40AM +0100, Stefan Roese wrote: > This patch adds a driver for the PCA9551 LED controller. > > Originated-by: Timo Herbrecher > Signed-off-by: Stefan Roese Reviewed-by: Tom Rini But: > +struct pca9551_blink_rate { > + u8 psc; /* Frequency preescaler, see PCA9551_7.pdf p. 6 */ > + u8 pwm; /* Pulse width modulation, see PCA9551_7.pdf p. 6 */ > +} __packed; Yes, really, this must be packed because otherwise we get unwanted padding in between these u8s? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: