* [patch] Input: sx8654 - signedness bug in sx8654_irq()
@ 2015-03-11 9:37 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-11 9:37 UTC (permalink / raw)
To: Dmitry Torokhov, Sébastien Szymanski; +Cc: linux-input, kernel-janitors
"irqsrc" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
index 8e531ac..aecb9ad 100644
--- a/drivers/input/touchscreen/sx8654.c
+++ b/drivers/input/touchscreen/sx8654.c
@@ -79,7 +79,7 @@ struct sx8654 {
static irqreturn_t sx8654_irq(int irq, void *handle)
{
struct sx8654 *sx8654 = handle;
- u8 irqsrc;
+ int irqsrc;
u8 data[4];
unsigned int x, y;
int retval;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] Input: sx8654 - signedness bug in sx8654_irq()
@ 2015-03-11 9:37 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-03-11 9:37 UTC (permalink / raw)
To: Dmitry Torokhov, Sébastien Szymanski; +Cc: linux-input, kernel-janitors
"irqsrc" needs to be signed for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
index 8e531ac..aecb9ad 100644
--- a/drivers/input/touchscreen/sx8654.c
+++ b/drivers/input/touchscreen/sx8654.c
@@ -79,7 +79,7 @@ struct sx8654 {
static irqreturn_t sx8654_irq(int irq, void *handle)
{
struct sx8654 *sx8654 = handle;
- u8 irqsrc;
+ int irqsrc;
u8 data[4];
unsigned int x, y;
int retval;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] Input: sx8654 - signedness bug in sx8654_irq()
2015-03-11 9:37 ` Dan Carpenter
@ 2015-03-11 17:43 ` Dmitry Torokhov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-03-11 17:43 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sébastien Szymanski, linux-input, kernel-janitors
On Wed, Mar 11, 2015 at 12:37:07PM +0300, Dan Carpenter wrote:
> "irqsrc" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thank you.
> diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
> index 8e531ac..aecb9ad 100644
> --- a/drivers/input/touchscreen/sx8654.c
> +++ b/drivers/input/touchscreen/sx8654.c
> @@ -79,7 +79,7 @@ struct sx8654 {
> static irqreturn_t sx8654_irq(int irq, void *handle)
> {
> struct sx8654 *sx8654 = handle;
> - u8 irqsrc;
> + int irqsrc;
> u8 data[4];
> unsigned int x, y;
> int retval;
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Input: sx8654 - signedness bug in sx8654_irq()
@ 2015-03-11 17:43 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2015-03-11 17:43 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Sébastien Szymanski, linux-input, kernel-janitors
On Wed, Mar 11, 2015 at 12:37:07PM +0300, Dan Carpenter wrote:
> "irqsrc" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thank you.
> diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
> index 8e531ac..aecb9ad 100644
> --- a/drivers/input/touchscreen/sx8654.c
> +++ b/drivers/input/touchscreen/sx8654.c
> @@ -79,7 +79,7 @@ struct sx8654 {
> static irqreturn_t sx8654_irq(int irq, void *handle)
> {
> struct sx8654 *sx8654 = handle;
> - u8 irqsrc;
> + int irqsrc;
> u8 data[4];
> unsigned int x, y;
> int retval;
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-11 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-11 9:37 [patch] Input: sx8654 - signedness bug in sx8654_irq() Dan Carpenter
2015-03-11 9:37 ` Dan Carpenter
2015-03-11 17:43 ` Dmitry Torokhov
2015-03-11 17:43 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.