All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Tim Small <tim@buttersideup.com>,
	kernel-janitors@vger.kernel.org,
	Doug Thompson <dougthompson@xmission.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
Date: Wed, 11 Mar 2015 20:48:02 +0100	[thread overview]
Message-ID: <20150311194801.GC3359@pd.tnic> (raw)
In-Reply-To: <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>

On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
> 
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.

Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

WARNING: multiple messages have this Message-ID
From: Borislav Petkov <bp@alien8.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Tim Small <tim@buttersideup.com>,
	kernel-janitors@vger.kernel.org,
	Doug Thompson <dougthompson@xmission.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
Date: Wed, 11 Mar 2015 19:48:02 +0000	[thread overview]
Message-ID: <20150311194801.GC3359@pd.tnic> (raw)
In-Reply-To: <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>

On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
> 
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.

Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  reply	other threads:[~2015-03-11 19:49 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 16:56 [PATCH 0/15] don't export static symbol Julia Lawall
2015-03-11 16:56 ` Julia Lawall
2015-03-11 16:56 ` Julia Lawall
2015-03-11 16:56 ` Julia Lawall
2015-03-11 16:56 ` [PATCH 1/15] NFSv4.1: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-12 15:59   ` Trond Myklebust
2015-03-12 15:59     ` Trond Myklebust
2015-03-11 16:56 ` [PATCH 2/15] powerpc: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56 ` [PATCH 3/15] net/mlx5_core: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-12  4:04   ` David Miller
2015-03-12  4:04     ` David Miller
2015-03-11 16:56 ` [PATCH 4/15] crypto: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-13 10:38   ` Herbert Xu
2015-03-13 10:38     ` Herbert Xu
2015-03-11 16:56 ` [PATCH 5/15] clockevents: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56 ` [PATCH 6/15] torture: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56 ` [PATCH 7/15] media: pci: cx23885: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56 ` [PATCH 8/15] libertas_tf: if_usb.c: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-13 14:18   ` [8/15] " Kalle Valo
2015-03-13 14:18     ` Kalle Valo
2015-03-11 16:56 ` [PATCH 9/15] clk: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-12  6:03   ` Stephen Boyd
2015-03-12  6:03     ` Stephen Boyd
2015-03-11 16:56 ` [PATCH 10/15] scsi: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56 ` [PATCH 11/15] ASoC: ab8500-codec: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 18:29   ` Mark Brown
2015-03-11 16:56 ` [PATCH 12/15] i82443bxgx_edac: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 19:48   ` Borislav Petkov [this message]
2015-03-11 19:48     ` Borislav Petkov
2015-03-11 16:56 ` [PATCH 13/15] ieee802154: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 18:17   ` Alexander Aring
2015-03-11 18:17     ` Alexander Aring
2015-03-14 16:13   ` Marcel Holtmann
2015-03-14 16:13     ` Marcel Holtmann
2015-03-11 16:56 ` [PATCH 14/15] ARM: cns3xxx: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-11 21:09   ` Arnd Bergmann
2015-03-11 21:09     ` Arnd Bergmann
2015-03-11 21:09     ` Arnd Bergmann
2015-03-13  5:59     ` Krzysztof Hałasa
2015-03-13  5:59       ` Krzysztof Hałasa
2015-03-13  5:59       ` Krzysztof Hałasa
2015-03-13 10:04       ` Arnd Bergmann
2015-03-13 10:04         ` Arnd Bergmann
2015-03-13 10:04         ` Arnd Bergmann
2015-03-11 16:56 ` [PATCH 15/15] iscsi-target: " Julia Lawall
2015-03-11 16:56   ` Julia Lawall
2015-03-20 18:42   ` Nicholas A. Bellinger
2015-03-20 18:42     ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311194801.GC3359@pd.tnic \
    --to=bp@alien8.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=dougthompson@xmission.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=tim@buttersideup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.