From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752129AbbCKTta (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 15:49:30 -0400
Received: from mail.skyhub.de ([78.46.96.112]:47631 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751554AbbCKTt1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 15:49:27 -0400
Date: Wed, 11 Mar 2015 20:48:02 +0100
From: Borislav Petkov <bp@alien8.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Tim Small <tim@buttersideup.com>, kernel-janitors@vger.kernel.org,
        Doug Thompson <dougthompson@xmission.com>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
Message-ID: <20150311194801.GC3359@pd.tnic>
References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr>
 <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
> 
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.

Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Borislav Petkov <bp@alien8.de>
Date: Wed, 11 Mar 2015 19:48:02 +0000
Subject: Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
Message-Id: <20150311194801.GC3359@pd.tnic>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1426092997-30605-1-git-send-email-Julia.Lawall@lip6.fr>
 <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>
In-Reply-To: <1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Tim Small <tim@buttersideup.com>, kernel-janitors@vger.kernel.org, Doug Thompson <dougthompson@xmission.com>, Mauro Carvalho Chehab <mchehab@osg.samsung.com>, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
> 
> static T f (...) { ... }
> 
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
> 
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks.

Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--