All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] perf, tools: Output running time and run/enabled ratio in CSV mode
Date: Wed, 11 Mar 2015 21:42:19 +0100	[thread overview]
Message-ID: <20150311204219.GA8369@krava.redhat.com> (raw)
In-Reply-To: <20150311195326.GB926@kernel.org>

On Wed, Mar 11, 2015 at 04:53:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 11, 2015 at 08:28:00AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The information how much a counter ran in perf stat can be quite
> > interesting for other tools to judge how trustworthy a measurement is.
> > 
> > Currently it is only output in non CSV mode.
> > 
> > This patches make perf stat always output the running time and the
> > enabled/running ratio in CSV mode.
> > 
> > This adds two new fields at the end for each line. I assume that existing
> > tools ignore new fields at the end, so it's on by default.
> > 
> > Only CSV mode is affected, no difference otherwise.
> > 
> > v2: Add extra print_running function
> > v3: Avoid printing nan
> > v4: Remove some elses and add brackets.
> > v5: Move non CSV case into print_running
> > Reviewed-by: Jiri Olsa <jolsa@redhat.com>
> 
> Jiri, have you sent that "Reviewed-by" tag? Don't remember seeing it.

I might have, but can't find it now..
anyway there's new version, I'll check it

jirka

      reply	other threads:[~2015-03-11 20:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 15:28 [PATCH 1/3] perf, tools: Output running time and run/enabled ratio in CSV mode Andi Kleen
2015-03-11 15:28 ` [PATCH 2/3] perf, tools, stat: Fix IPC and other formulas with -A Andi Kleen
2015-03-14  7:05   ` [tip:perf/core] perf " tip-bot for Andi Kleen
2015-03-11 15:28 ` [PATCH 3/3] perf, tools, stat: Always correctly indent ratio column Andi Kleen
2015-03-14  7:06   ` [tip:perf/core] perf " tip-bot for Andi Kleen
2015-03-11 19:53 ` [PATCH 1/3] perf, tools: Output running time and run/enabled ratio in CSV mode Arnaldo Carvalho de Melo
2015-03-11 20:42   ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311204219.GA8369@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.