From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752667AbbCKUmb (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 16:42:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50271 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752045AbbCKUma (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 16:42:30 -0400
Date: Wed, 11 Mar 2015 21:42:19 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] perf, tools: Output running time and run/enabled
 ratio in CSV mode
Message-ID: <20150311204219.GA8369@krava.redhat.com>
References: <1426087682-22765-1-git-send-email-andi@firstfloor.org>
 <20150311195326.GB926@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150311195326.GB926@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 04:53:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 11, 2015 at 08:28:00AM -0700, Andi Kleen escreveu:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The information how much a counter ran in perf stat can be quite
> > interesting for other tools to judge how trustworthy a measurement is.
> > 
> > Currently it is only output in non CSV mode.
> > 
> > This patches make perf stat always output the running time and the
> > enabled/running ratio in CSV mode.
> > 
> > This adds two new fields at the end for each line. I assume that existing
> > tools ignore new fields at the end, so it's on by default.
> > 
> > Only CSV mode is affected, no difference otherwise.
> > 
> > v2: Add extra print_running function
> > v3: Avoid printing nan
> > v4: Remove some elses and add brackets.
> > v5: Move non CSV case into print_running
> > Reviewed-by: Jiri Olsa <jolsa@redhat.com>
> 
> Jiri, have you sent that "Reviewed-by" tag? Don't remember seeing it.

I might have, but can't find it now..
anyway there's new version, I'll check it

jirka