Re: [PATCH v3] HID: multitouch: Add support for button type usage

[Seth Forshee <seth.forshee@canonical.com>]

On Wed, Mar 11, 2015 at 04:55:59PM -0400, Benjamin Tissoires wrote:
> Hi Seth,
> 
> On Mar 11 2015 or thereabouts, Seth Forshee wrote:
> > According to [1], Windows Precision Touchpad devices must supply
> > a button type usage in the device capabilities feature report. A
> > value of 0 indicates that the device contains a depressible
> > button (i.e. it's a click-pad) whereas a value of 1 indicates
> > a non-depressible button. Add support for this usage and set
> > INPUT_PROP_BUTTONPAD on the touchpad input device whenever a
> > depressible button is present.
> > 
> > v2: Add string for button type usage in debugfs.
> > v3: Fix conflicts with 015fdaa9f8ed ("HID: multitouch: add
> >     support of clickpads").
> > 
> > [1] https://msdn.microsoft.com/en-us/library/windows/hardware/dn467314(v=vs.85).aspx
> > 
> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> > ---
> 
> [Replying to the previous thread here for convenience]
> 
> Sorry I might have overlooked your patch and forgot about it when I sent
> mine. I should definitively have looked at this in detail because that's
> a better approach IMO.
> However, the patch I sent allows to handle clickpads which are not
> following MS spec, so I think your v3 on top of mine makes sense.
> 
> I have a few bike-shedding if you don't mind:

Sure, I opted to maintain the terminology from the MS spec but I have no
problem doing it that way. I'll follow up with another patch once I get
it tested.