From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVzRg-0001KM-08 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:30:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YVzRa-0001El-BG for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:30:23 -0400 Received: from ozlabs.org ([103.22.144.67]:48354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YVzRa-0001DI-08 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 05:30:18 -0400 Date: Thu, 12 Mar 2015 17:14:33 +1100 From: David Gibson Message-ID: <20150312061433.GV11973@voom.redhat.com> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-17-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eGyD7iWN192kf2IJ" Content-Disposition: inline In-Reply-To: <1424883128-9841-17-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 16/45] Add migration-capability boolean for postcopy-ram. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com --eGyD7iWN192kf2IJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 25, 2015 at 04:51:39PM +0000, Dr. David Alan Gilbert (git) wrot= e: > From: "Dr. David Alan Gilbert" This absolutely needs a commit message. I shouldn't have to look at the code to find out what the presence of this capability asserts, and =66rom where to where it's communicating that information. > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake > --- > include/migration/migration.h | 1 + > migration/migration.c | 9 +++++++++ > qapi-schema.json | 7 ++++++- > 3 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/include/migration/migration.h b/include/migration/migration.h > index 751caa0..f94af5b 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -177,6 +177,7 @@ void migrate_add_blocker(Error *reason); > */ > void migrate_del_blocker(Error *reason); > =20 > +bool migrate_postcopy_ram(void); > bool migrate_rdma_pin_all(void); > bool migrate_zero_blocks(void); > =20 > diff --git a/migration/migration.c b/migration/migration.c > index 4592060..434864a 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -663,6 +663,15 @@ bool migrate_rdma_pin_all(void) > return s->enabled_capabilities[MIGRATION_CAPABILITY_RDMA_PIN_ALL]; > } > =20 > +bool migrate_postcopy_ram(void) > +{ > + MigrationState *s; > + > + s =3D migrate_get_current(); > + > + return s->enabled_capabilities[MIGRATION_CAPABILITY_X_POSTCOPY_RAM]; As an asside, I'm assuming you'll get rid of these "x-" prefixes before you post a series intended for final inclusion? > +} > + > bool migrate_auto_converge(void) > { > MigrationState *s; > diff --git a/qapi-schema.json b/qapi-schema.json > index e16f8eb..a8af1cb 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -494,10 +494,15 @@ > # @auto-converge: If enabled, QEMU will automatically throttle down the = guest > # to speed up convergence of RAM migration. (since 1.6) > # > +# @x-postcopy-ram: Start executing on the migration target before all of= RAM has > +# been migrated, pulling the remaining pages along as needed. N= OTE: If > +# the migration fails during postcopy the VM will fail. (since= 2.3) > +# > # Since: 1.2 > ## > { 'enum': 'MigrationCapability', > - 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks'] } > + 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', > + 'x-postcopy-ram'] } > =20 > ## > # @MigrationCapabilityStatus --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --eGyD7iWN192kf2IJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVAS7JAAoJEGw4ysog2bOS2pUQAIVcE7ydevifMrJIGyw4bjSH C8biqDWA+8M9XI+C7kvRbrobReOaZgnfeKd0c1DlnIJOszHeNzMpxd2HACimcRIw TAOkzfO3JiAwJVtRbCRFiHs6kKxv6eGFBZxvnTHcXBw7NPM6QSCpo26OYXzreOZU usp23H0RFcsD5xsmwfruHmi3PDpjTOxpXal3USIliX1EqIPBVM8f+9HvyRn1LLm0 5cA+185ukfzjU5fw3Qi6BNh4cmc3oHeq3mPi6ixreGNMpHA8fDDP36lHx1l6x0Nl cBfWD4ZAIwpxCj4T9OS+zbKAYHYmq6GZ0PpAl0ua6G0yOKEV0l+NYXjan2DgugM0 vDw7uH7CCG4rHQlrxO2AKSOvZT0RfqtlkYn9owNa4lz/7u7EYVk0tNI1CzHDyrRQ W+ZT+MlEyDTlJr5di0fFM2VsTN22Nzq/7HC1AZSHBS4pz3hcT9qw5A08GBGcCDMg yy46qqC83lS7zLPG9o0bBaAIR194nn+rMIjadgHXLfIaJqovMNgkXOE/B/SkpmE+ 7eoZ+WYy6i09XXDBakZXWnBRSznuE2uYAPAZjU/FcRr7nFwDLfCrmbzoDmE5BROe OXMdN6Rg8lyQmkH2nP0xn6RDRee5NUriby7yWYfYjBVCE6u/HMf5piDFO8bf49RB QGRB0/T2K3862xgH8eZh =RJog -----END PGP SIGNATURE----- --eGyD7iWN192kf2IJ--