From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbCLHWE (ORCPT ); Thu, 12 Mar 2015 03:22:04 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:58580 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbbCLHWB (ORCPT ); Thu, 12 Mar 2015 03:22:01 -0400 Date: Thu, 12 Mar 2015 08:21:54 +0100 From: Sascha Hauer To: Kevin Hilman Cc: James Liao , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver Message-ID: <20150312072154.GB24885@pengutronix.de> References: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> <1425888603-25800-3-git-send-email-s.hauer@pengutronix.de> <7h61a94zy0.fsf@deeprootsystems.com> <20150310094142.GD24885@pengutronix.de> <1426043791.24243.9.camel@mtksdaap41> <20150311090345.GR24885@pengutronix.de> <7hbnjzxxqo.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7hbnjzxxqo.fsf@deeprootsystems.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:20:06 up 2 days, 22:41, 56 users, load average: 0.00, 0.01, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 10:14:23AM -0700, Kevin Hilman wrote: > Sascha Hauer writes: > > >> I asked our designer about the bus protection feature, here is his > >> response: > >> > >> " > >> It's for unexpected signal glitch in Power switch process. > >> > >> During Power switch process, we have clock switch, reset, isolation > >> enable/disable and power switch involved where the transition of > >> asynchronous reset and isolation is the most critical one, which have > >> risk to introduce a unexpected short period signal transition from > >> MTCMOS’s interface to other alive HW . > >> " > >> > >> That means it protects unexpected bus accessing from HW, not from SW. So > >> it will not hide bugs from wrong SW access. > > > > Ok, thanks for clarifying. This means we should enable this feature > > sooner or later. Since the audio driver which is likely the first user > > of this driver doesn't need the protection bits I think we have some > > time and can add the protection bits once the clock patches have been > > merged. > > Sounds OK to me. > > But I still think it belongs in the infracfg layer, and not in the PM > domain layer. I already have plans how to put the code into the infracfg driver. Where the code is going to be called from remains to be seen. The power domain driver might or might not be a good place for it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Thu, 12 Mar 2015 08:21:54 +0100 Subject: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver In-Reply-To: <7hbnjzxxqo.fsf@deeprootsystems.com> References: <1425888603-25800-1-git-send-email-s.hauer@pengutronix.de> <1425888603-25800-3-git-send-email-s.hauer@pengutronix.de> <7h61a94zy0.fsf@deeprootsystems.com> <20150310094142.GD24885@pengutronix.de> <1426043791.24243.9.camel@mtksdaap41> <20150311090345.GR24885@pengutronix.de> <7hbnjzxxqo.fsf@deeprootsystems.com> Message-ID: <20150312072154.GB24885@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 11, 2015 at 10:14:23AM -0700, Kevin Hilman wrote: > Sascha Hauer writes: > > >> I asked our designer about the bus protection feature, here is his > >> response: > >> > >> " > >> It's for unexpected signal glitch in Power switch process. > >> > >> During Power switch process, we have clock switch, reset, isolation > >> enable/disable and power switch involved where the transition of > >> asynchronous reset and isolation is the most critical one, which have > >> risk to introduce a unexpected short period signal transition from > >> MTCMOS?s interface to other alive HW . > >> " > >> > >> That means it protects unexpected bus accessing from HW, not from SW. So > >> it will not hide bugs from wrong SW access. > > > > Ok, thanks for clarifying. This means we should enable this feature > > sooner or later. Since the audio driver which is likely the first user > > of this driver doesn't need the protection bits I think we have some > > time and can add the protection bits once the clock patches have been > > merged. > > Sounds OK to me. > > But I still think it belongs in the infracfg layer, and not in the PM > domain layer. I already have plans how to put the code into the infracfg driver. Where the code is going to be called from remains to be seen. The power domain driver might or might not be a good place for it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |