From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903AbbCLJ7H (ORCPT ); Thu, 12 Mar 2015 05:59:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33337 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbbCLJ67 (ORCPT ); Thu, 12 Mar 2015 05:58:59 -0400 Date: Thu, 12 Mar 2015 10:58:54 +0100 From: Greg Kroah-Hartman To: Quentin Lambert Cc: Dan Carpenter , Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= , Lidza Louina , Mark Hounschell , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling Message-ID: <20150312095854.GA3682@kroah.com> References: <20150311140433.GA17051@sloth> <55006F4A.70805@gmail.com> <20150312092711.GX10964@mwanda> <55015D38.5060100@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55015D38.5060100@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 10:32:40AM +0100, Quentin Lambert wrote: > > > On 12/03/2015 10:27, Dan Carpenter wrote: > >On Wed, Mar 11, 2015 at 06:37:30PM +0200, Giedrius Statkevičius wrote: > >>It's still not in staging-testing for some reason :( > >> > >It can take several weeks to get merged. Relax. > > > >regards, > >dan carpenter > > > What should i do concerning that ? > I need to send a second version of this patch anyway to fix the > fact that i inverted 2 statements, namely: > > +exit_unlock: > + if (ld) > + tty_ldisc_deref(ld); > + spin_unlock_irqrestore(&ch->ch_lock, flags); > > should be > > +exit_unlock: > + spin_unlock_irqrestore(&ch->ch_lock, flags); > + if (ld) > + tty_ldisc_deref(ld); > > Should I wait these several weeks to send the second version or should > I send a second version fixing this issue a wait for someone to ask me > to solve the conflict ? Just wait a bit, I should catch up on patches in this area soon, and I will let everyone know if patches do not apply. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Thu, 12 Mar 2015 09:58:54 +0000 Subject: Re: [PATCH 2/3] Staging: dgnc: Use goto for error handling Message-Id: <20150312095854.GA3682@kroah.com> List-Id: References: <20150311140433.GA17051@sloth> <55006F4A.70805@gmail.com> <20150312092711.GX10964@mwanda> <55015D38.5060100@gmail.com> In-Reply-To: <55015D38.5060100@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: Quentin Lambert Cc: Dan Carpenter , Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= , Lidza Louina , Mark Hounschell , devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org T24gVGh1LCBNYXIgMTIsIDIwMTUgYXQgMTA6MzI6NDBBTSArMDEwMCwgUXVlbnRpbiBMYW1iZXJ0 IHdyb3RlOgo+IAo+IAo+IE9uIDEyLzAzLzIwMTUgMTA6MjcsIERhbiBDYXJwZW50ZXIgd3JvdGU6 Cj4gPk9uIFdlZCwgTWFyIDExLCAyMDE1IGF0IDA2OjM3OjMwUE0gKzAyMDAsIEdpZWRyaXVzIFN0 YXRrZXZpxI1pdXMgd3JvdGU6Cj4gPj5JdCdzIHN0aWxsIG5vdCBpbiBzdGFnaW5nLXRlc3Rpbmcg Zm9yIHNvbWUgcmVhc29uIDooCj4gPj4KPiA+SXQgY2FuIHRha2Ugc2V2ZXJhbCB3ZWVrcyB0byBn ZXQgbWVyZ2VkLiAgUmVsYXguCj4gPgo+ID5yZWdhcmRzLAo+ID5kYW4gY2FycGVudGVyCj4gPgo+ IFdoYXQgc2hvdWxkIGkgZG8gY29uY2VybmluZyB0aGF0ID8KPiBJIG5lZWQgdG8gc2VuZCBhIHNl Y29uZCB2ZXJzaW9uIG9mIHRoaXMgcGF0Y2ggYW55d2F5IHRvIGZpeCB0aGUKPiBmYWN0IHRoYXQg aSBpbnZlcnRlZCAyIHN0YXRlbWVudHMsIG5hbWVseToKPiAKPiArZXhpdF91bmxvY2s6Cj4gKwlp ZiAobGQpCj4gKwkJdHR5X2xkaXNjX2RlcmVmKGxkKTsKPiArCXNwaW5fdW5sb2NrX2lycXJlc3Rv cmUoJmNoLT5jaF9sb2NrLCBmbGFncyk7Cj4gCj4gc2hvdWxkIGJlCj4gCj4gK2V4aXRfdW5sb2Nr Ogo+ICsJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY2gtPmNoX2xvY2ssIGZsYWdzKTsKPiArCWlm IChsZCkKPiArCQl0dHlfbGRpc2NfZGVyZWYobGQpOwo+IAo+IFNob3VsZCBJIHdhaXQgdGhlc2Ug c2V2ZXJhbCB3ZWVrcyB0byBzZW5kIHRoZSBzZWNvbmQgdmVyc2lvbiBvciBzaG91bGQKPiBJIHNl bmQgYSBzZWNvbmQgdmVyc2lvbiBmaXhpbmcgdGhpcyBpc3N1ZSBhIHdhaXQgZm9yIHNvbWVvbmUg dG8gYXNrIG1lCj4gdG8gc29sdmUgdGhlIGNvbmZsaWN0ID8KCkp1c3Qgd2FpdCBhIGJpdCwgSSBz aG91bGQgY2F0Y2ggdXAgb24gcGF0Y2hlcyBpbiB0aGlzIGFyZWEgc29vbiwgYW5kIEkKd2lsbCBs ZXQgZXZlcnlvbmUga25vdyBpZiBwYXRjaGVzIGRvIG5vdCBhcHBseS4KCnRoYW5rcywKCmdyZWcg ay1oCi0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1 YnNjcmliZSBrZXJuZWwtamFuaXRvcnMiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA==