From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH V6 13/13] xen/vm_event: Add RESUME option to vm_event_op domctl Date: Thu, 12 Mar 2015 16:56:04 +0100 Message-ID: <20150312155604.GJ22158@deinos.phlegethon.org> References: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com> <1424218303-11331-14-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1424218303-11331-14-git-send-email-tamas.lengyel@zentific.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, steve@zentific.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jbeulich@suse.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org At 01:11 +0100 on 18 Feb (1424218303), Tamas K Lengyel wrote: > Thus far mem_access and mem_sharing memops had been able to signal > to Xen to start pulling responses off the corresponding rings. In this patch > we retire these memops and add them to the option to the vm_event_op domctl. > > The vm_event_op domctl suboptions are the same for each ring thus we > consolidate them into XEN_VM_EVENT_ENABLE/DISABLE/RESUME. > > As part of this patch in libxc we also rename the mem_access_enable/disable > functions to monitor_enable/disable and move them into xc_monitor.c. > > Signed-off-by: Tamas K Lengyel > Acked-by: Wei Liu I think there's still an outstanding question about the repeated code in vm_event.c, which could be unified -- last time you suggested maybe just getting rid of the wakeup operation entirely. Nevertheless I think this patch is good on its own. So, Acked-by: Tim Deegan Cheers, Tim