From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Deegan Subject: Re: [PATCH V6 00/13] xen: Clean-up of mem_event subsystem Date: Thu, 12 Mar 2015 16:58:05 +0100 Message-ID: <20150312155805.GK22158@deinos.phlegethon.org> References: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1424218303-11331-1-git-send-email-tamas.lengyel@zentific.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, steve@zentific.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, eddie.dong@intel.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jbeulich@suse.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org Hi, At 01:11 +0100 on 18 Feb (1424218290), Tamas K Lengyel wrote: > This patch series aims to clean up the mem_event subsystem within Xen. The > original use-case for this system was to allow external helper applications > running in privileged domains to control various memory operations performed > by Xen. Amongs these were paging, sharing and access control. The subsystem > has since been extended to also deliver non-memory related events, namely > various HVM debugging events (INT3, MTF, MOV-TO-CR, MOV-TO-MSR). The structures > and naming of related functions however has not caught up to these new > use-cases, thus leaving many ambiguities in the code. Furthermore, future > use-cases envisioned for this subsystem include PV domains and ARM domains, > thus there is a need to establish a common base to build on. > > In this series we convert the mem_event system to vm_event in which we clearly > define the scope of information that is transmitted via the event > delivery mechanism. Afterwards, we clean up the naming of the structures and > related functions to more clearly be in line with their actual operations. > Finally, the control of monitor events is moved to a new domctl, monitor_op. I've read through these and except for the comments I made on patch #11, it looks good to me. You can add my ack to patches 9, 10 and 12 as well as the ones I replied to separately. Cheers, Tim.