From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW9Fe-0002E3-Bi for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW9Fa-0007sh-4f for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:58:38 -0400 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:37403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW9FZ-0007sZ-Tp for qemu-devel@nongnu.org; Thu, 12 Mar 2015 15:58:34 -0400 Received: by wggx13 with SMTP id x13so18795919wgg.4 for ; Thu, 12 Mar 2015 12:58:33 -0700 (PDT) Date: Thu, 12 Mar 2015 19:58:30 +0000 From: Stefan Hajnoczi Message-ID: <20150312195830.GA7716@stefanha-thinkpad.redhat.com> References: <1426170808-6343-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v4 00/11] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: dsahern@gmail.com, jiri@resnulli.us, sfeldma@gmail.com Cc: Peter Maydell , QEMU Developers , Stefan Hajnoczi --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2015 at 03:03:45PM +0000, Peter Maydell wrote: > On 12 March 2015 at 14:43, Peter Maydell wrote: > > On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: > >> v4: > >> * Drop clang 3.5.0 fixes since they break with older clang and w32 [P= eter] > >> > >> v3: > >> * Add clang 3.5.0 warning fixes > >> * Squash David Ahern's clang struct definition warnings fix > >> > >> v2: > >> * Squash in Jiri's fix for rocker format string specifiers [Peter] > >> * Squash in Windows build fix [Peter] > >> * Both build fixes are described in "rocker: add new rocker switch de= vice" > >> > >> The following changes since commit ee74801035b0b5f1fdfd4e31d3a53f511f9= 1c804: > >> > >> Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150311' int= o staging (2015-03-11 18:22:15 +0000) > >> > >> are available in the git repository at: > >> > >> git://github.com/stefanha/qemu.git tags/net-pull-request > >> > >> for you to fetch changes up to 8d3f4f565fb4adf940a8824882a7f549304f34f= d: > >> > >> rocker: timestamp on the debug logs helps correlate with events in t= he VM (2015-03-12 14:18:11 +0000) > > > > w32 build failure :-( > > > > cc1: warnings being treated as errors > > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c: In > > function 'rocker_io_readq': > > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:1109: > > warning: integer constant is too large for 'long' type > > > > (64 bit constant without ULL suffix.) >=20 > Also fails to build with our minimum glib version: >=20 > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c: > In function 'of_dpa_init': > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: 'g_int64_hash' undeclared (first use in this function) > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: (Each undeclared identifier is reported only once > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: for each function it appears in.) > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: 'g_int64_equal' undeclared (first use in this function) >=20 > (Both first introduced in glib 2.22.) I'm dropping the rocker patch series. David, Jiri, Scott: The minimum required glib version is 2.12 so glib APIs that were added later cannot be used. Also note the Windows integer constant warning above. My build environments didn't hit these issues so we need to go around one more time. Please post fixes. Stefan --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVAe/mAAoJEJykq7OBq3PIRloH/iBhtE/Fy/nv1zOST0tS/tds X4ZWnq6yY5Lwm2B7MmsfNONFwqNra+kLnh+b1xEZNhX1oH40/S8/tJPPPg54UeYj OfIOq2tHcaD0iA67m7lOhNfXmWler7NEQIKmxj+kMGU9H/Pu8GzgPx+y2xNDdXED EjMRdy/dNy7Do6W1k8rgTqOQC2s51De+IcGVp/wkENwZsCYoi3WgPGeG5AM4Z5+R gHW874LApaJjOSwApCKpfb93HMAJwdYTUpIHYDF4AIl8pN45mZhdQyzbO/P3WACS 76rvTbBmDMmGpmtt6VM7+A/fiIqOjnBCPZ31jrL9kzGtOGaPWvCu+ANXYqQt3yM= =NXkR -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--