From: Herbert Xu <herbert@gondor.apana.org.au>
To: Thomas Graf <tgraf@suug.ch>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rhashtable: Fix race between rehashing and readers
Date: Fri, 13 Mar 2015 08:50:02 +1100 [thread overview]
Message-ID: <20150312215002.GB20117@gondor.apana.org.au> (raw)
In-Reply-To: <20150312163348.GD5378@casper.infradead.org>
On Thu, Mar 12, 2015 at 04:33:48PM +0000, Thomas Graf wrote:
> Rehashing can occur in parallel to readers. Readers are aware of this
> situation so new readers are allowed while the rehashing is in
> process. Existing readers may have already fetched the tbl and
> future_tbl and may thus assume no rehashing is in progress. The
> rehashing must thus wait for all existing readers to complete after
> publihsing the future_tbl to make sure all parallel readers see the
> table before we start moving entries.
>
> Fixes: aa34a6cb0478 ("rhashtable: Add arbitrary rehash function")
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> ---
> Herbert: This is what I think is needed to fix this properly.
Nack. Please see my previous email.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-03-12 21:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 11:07 rhashtable: Fix reader/rehash race Herbert Xu
2015-03-12 13:37 ` Thomas Graf
2015-03-12 16:33 ` [PATCH net-next] rhashtable: Fix race between rehashing and readers Thomas Graf
2015-03-12 21:50 ` Herbert Xu [this message]
2015-03-12 21:49 ` rhashtable: Fix reader/rehash race Herbert Xu
2015-03-13 10:32 ` Thomas Graf
2015-03-13 10:36 ` Herbert Xu
2015-03-13 10:54 ` Thomas Graf
2015-03-13 3:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312215002.GB20117@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.