From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbbCME66 (ORCPT ); Fri, 13 Mar 2015 00:58:58 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:40228 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbCME6z (ORCPT ); Fri, 13 Mar 2015 00:58:55 -0400 Date: Fri, 13 Mar 2015 10:28:47 +0530 From: Sudip Mukherjee To: Ragavendra BN Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix Message-ID: <20150313045847.GB3687@sudip-PC> References: <20150313034333.GA10618@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313034333.GA10618@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote: > Signed-off-by: Ragavendra BN > > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the code give no > warnings by the checkpath.pl script check. > Signed-off-by line should come here before the --- > --- not at the top like you are giving. Greg has told you once, I am telling now for the second time. regards sudip From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Fri, 13 Mar 2015 04:58:57 +0000 Subject: Re: [PATCH] staging: sm750fb: braces, indents, spaces fix Message-Id: <20150313045847.GB3687@sudip-PC> List-Id: References: <20150313034333.GA10618@localhost.localdomain> In-Reply-To: <20150313034333.GA10618@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ragavendra BN Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote: > Signed-off-by: Ragavendra BN > > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the code give no > warnings by the checkpath.pl script check. > Signed-off-by line should come here before the --- > --- not at the top like you are giving. Greg has told you once, I am telling now for the second time. regards sudip