From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOec-0004aH-VE for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWOeb-0008K7-P3 for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWOeb-0008JW-FO for qemu-devel@nongnu.org; Fri, 13 Mar 2015 08:25:25 -0400 Date: Fri, 13 Mar 2015 12:25:12 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150313122511.GF2486@work-vm> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-26-git-send-email-dgilbert@redhat.com> <20150313045804.GD11973@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150313045804.GD11973@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 25/45] qemu_savevm_state_complete: Postcopy changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com * David Gibson (david@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:48PM +0000, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When postcopy calls qemu_savevm_state_complete it's not really > > the end of migration, so skip: > > Given that, maybe the name should change.. The name reflects that it calls the save_live_complete method on each device, so if we wanted to remove the 'complete' from the name we'd probably want to change the method name everywhere; and anyway it does complete most devices; the only exception are devices that are postcopiable. > > a) Finishing postcopiable iterative devices - they'll carry on > > b) The termination byte on the end of the stream. > > > > We then also add: > > qemu_savevm_state_postcopy_complete > > which is called at the end of a postcopy migration to call the > > complete methods on devices skipped in the _complete call. > > > > Signed-off-by: Dr. David Alan Gilbert > > Otherwise, > > Reviewed-by: David Gibson Thanks. Dave > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK