From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/15] package infra: drop non-lfs support
Date: Sat, 14 Mar 2015 23:46:13 +0100 [thread overview]
Message-ID: <20150314224613.GJ4009@free.fr> (raw)
In-Reply-To: <1426270934-15499-7-git-send-email-gustavo@zacarias.com.ar>
Gustavo, All,
On 2015-03-13 15:22 -0300, Gustavo Zacarias spake thusly:
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Review for both pathes 5 and 6: I think you should do it that way:
- patch 5: the hunk of Makefile.in from this patch, alone
- patch 6: remove use of $(DISABLE_LARGEFILE)
Granted, your proposal would work (with the additional patch I
suggested) because BR2_LARGEFILE is now always 'y'.
Still, I think it's better to get rid of DISABLE_LARGEFILE consistently.
Regards,
Yann E. MORIN.
> ---
> package/Makefile.in | 7 -------
> package/pkg-autotools.mk | 1 -
> 2 files changed, 8 deletions(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index 803b162..fc57427 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -136,10 +136,7 @@ ifeq ($(BR2_DEBUG_3),y)
> TARGET_DEBUGGING = -g3
> endif
>
> -ifeq ($(BR2_LARGEFILE),y)
> TARGET_CPPFLAGS += -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> -endif
> -
> TARGET_CFLAGS = $(TARGET_CPPFLAGS) $(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET_DEBUGGING)
> TARGET_CXXFLAGS = $(TARGET_CFLAGS)
> TARGET_LDFLAGS = $(call qstrip,$(BR2_TARGET_LDFLAGS))
> @@ -373,10 +370,6 @@ else
> DISABLE_NLS :=--disable-nls
> endif
>
> -ifneq ($(BR2_LARGEFILE),y)
> -DISABLE_LARGEFILE = --disable-largefile
> -endif
> -
> ifeq ($(BR2_INET_IPV6),y)
> DISABLE_IPV6 = --enable-ipv6
> else
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index d2f15fa..2ecf7d8 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -201,7 +201,6 @@ define $(2)_CONFIGURE_CMDS
> --with-fop=no \
> --disable-dependency-tracking \
> $$(DISABLE_NLS) \
> - $$(DISABLE_LARGEFILE) \
> $$(DISABLE_IPV6) \
> $$(ENABLE_DEBUG) \
> $$(SHARED_STATIC_LIBS_OPTS) \
> --
> 2.0.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-03-14 22:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 18:21 [Buildroot] [PATCH 00/15] Drop non-largefile support Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 01/15] toolchain/helpers: add mandatory check for uclibc toolchain options Gustavo Zacarias
2015-03-14 22:18 ` Yann E. MORIN
2015-03-17 12:18 ` Gustavo Zacarias
2015-03-17 14:13 ` Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 02/15] toolchain/helpers: make LFS mandatory for uclibc Gustavo Zacarias
2015-03-14 22:22 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 03/15] toolchain-common: default to Y for LARGEFILE Gustavo Zacarias
2015-03-14 22:34 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 04/15] toolchain: remove LARGEFILE selects Gustavo Zacarias
2015-03-14 22:36 ` Yann E. MORIN
2015-03-17 15:11 ` Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 05/15] gcc/final: drop non-lfs builds Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 06/15] package infra: drop non-lfs support Gustavo Zacarias
2015-03-14 22:46 ` Yann E. MORIN [this message]
2015-03-13 18:22 ` [Buildroot] [PATCH 07/15] package/uclibc: drop non-largefile support Gustavo Zacarias
2015-03-14 22:47 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 08/15] configs: drop largefile option Gustavo Zacarias
2015-03-14 22:47 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 09/15] busybox: force lfs build Gustavo Zacarias
2015-03-14 22:49 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 10/15] system: drop largefile depends Gustavo Zacarias
2015-03-14 22:50 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 11/15] boot/gummiboot: " Gustavo Zacarias
2015-03-14 22:52 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 12/15] packages: remove (non-)lfs dependencies and tweaks Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 13/15] toolchain-common: drop BR2_LARGEFILE Gustavo Zacarias
2015-03-14 22:53 ` Yann E. MORIN
2015-03-13 18:22 ` [Buildroot] [PATCH 14/15] packages: remove non-lfs enabler patches Gustavo Zacarias
2015-03-13 18:22 ` [Buildroot] [PATCH 15/15] docs/manual: remove references to largefile Gustavo Zacarias
2015-03-14 22:56 ` Yann E. MORIN
2015-03-14 22:58 ` [Buildroot] [PATCH 00/15] Drop non-largefile support Yann E. MORIN
2015-03-17 12:23 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150314224613.GJ4009@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.