All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] rtc: at91rm9200: double locking bug in at91_rtc_interrupt()
Date: Sun, 15 Mar 2015 10:48:37 +0000	[thread overview]
Message-ID: <20150315104837.GC20691@mwanda> (raw)

There is a typo here so we deadlock.

Fixes: dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index b4f7744..b283a1a 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
 
 		ret = IRQ_HANDLED;
 	}
-	spin_lock(&suspended_lock);
+	spin_unlock(&suspended_lock);
 
 	return ret;
 }

             reply	other threads:[~2015-03-15 10:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 10:48 Dan Carpenter [this message]
2015-03-15 11:01 ` [patch] rtc: at91rm9200: double locking bug in at91_rtc_interrupt() Boris Brezillon
2015-03-17 15:38 ` [PATCH] " Nicolas Ferre
2015-03-17 15:38   ` Nicolas Ferre
2015-03-17 15:38   ` Nicolas Ferre
2015-03-17 17:32   ` Dan Carpenter
2015-03-17 17:32     ` Dan Carpenter
2015-03-17 17:32     ` Dan Carpenter
2015-03-18  0:56   ` Rafael J. Wysocki
2015-03-18  1:20     ` Rafael J. Wysocki
2015-03-18  1:20     ` Rafael J. Wysocki
2015-03-17 15:39 ` [patch] " Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150315104837.GC20691@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.