From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2 net-next] rhashtable: Avoid calculating hash again to unlock
Date: Mon, 16 Mar 2015 17:15:00 -0400 (EDT) [thread overview]
Message-ID: <20150316.171500.2219680403539914280.davem@davemloft.net> (raw)
In-Reply-To: <20150316204836.GA6534@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 17 Mar 2015 07:48:36 +1100
> On Mon, Mar 16, 2015 at 04:22:02PM -0400, David Miller wrote:
>> From: Thomas Graf <tgraf@suug.ch>
>> Date: Mon, 16 Mar 2015 10:42:26 +0100
>>
>> > Caching the lock pointer avoids having to hash on the object
>> > again to unlock the bucket locks.
>> >
>> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
>>
>> I'd like to hold off on this.
>>
>> My understanding is that Herbert plans to expand the table size
>> synchonously during insert in emergency situations, and in that regime
>> some of these optimization won't be valid.
>
> Actually this patch does not conflict with my multiple rehashing
> work (the final scheme I used only requires two locks) so please
> feel free to merge it and I will rebase my stuff.
Ok, done, thanks.
next prev parent reply other threads:[~2015-03-16 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 9:42 [PATCH 0/2 net-next v2] Minor rhashtable fixes Thomas Graf
2015-03-16 9:42 ` [PATCH 1/2 net-next] rhashtable: Avoid calculating hash again to unlock Thomas Graf
2015-03-16 20:22 ` David Miller
2015-03-16 20:48 ` Herbert Xu
2015-03-16 21:15 ` David Miller [this message]
2015-03-16 9:42 ` [PATCH 2/2 net-next] rhashtable: Annotate RCU locking of walkers Thomas Graf
2015-03-16 20:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316.171500.2219680403539914280.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.