From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbbCPFd0 (ORCPT ); Mon, 16 Mar 2015 01:33:26 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:60305 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbCPFdY (ORCPT ); Mon, 16 Mar 2015 01:33:24 -0400 Date: Mon, 16 Mar 2015 06:33:18 +0100 From: Sascha Hauer To: Daniel Kurtz Cc: Mike Turquette , James Liao , YH Chen , "linux-kernel@vger.kernel.org" , Henry Chen , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger , Yingjoe Chen , Eddie Huang , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135. Message-ID: <20150316053318.GC24798@pengutronix.de> References: <1424605765-19751-1-git-send-email-s.hauer@pengutronix.de> <1424605765-19751-4-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:32:34 up 1 day, 17:54, 21 users, load average: 0.01, 0.02, 0.05 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 12:27:20AM +0800, Daniel Kurtz wrote: > Hi Sascha, > > Drive-by review... > > On Sun, Feb 22, 2015 at 7:49 PM, Sascha Hauer wrote: > > From: James Liao > > > > This patch adds basic clocks for MT8135, including TOPCKGEN, PLLs, > > INFRA and PERI clocks. > > > > Signed-off-by: James Liao > > Signed-off-by: Henry Chen > > Signed-off-by: Sascha Hauer > > --- > > drivers/clk/mediatek/Makefile | 1 + > > drivers/clk/mediatek/clk-mt8135.c | 634 +++++++++++++++++++++ > > include/dt-bindings/clock/mt8135-clk.h | 190 ++++++ > > .../dt-bindings/reset-controller/mt8135-resets.h | 64 +++ > > 4 files changed, 889 insertions(+) > > create mode 100644 drivers/clk/mediatek/clk-mt8135.c > > create mode 100644 include/dt-bindings/clock/mt8135-clk.h > > create mode 100644 include/dt-bindings/reset-controller/mt8135-resets.h > > > > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > > index 0b6f1c3..12ce576 100644 > > --- a/drivers/clk/mediatek/Makefile > > +++ b/drivers/clk/mediatek/Makefile > > @@ -1,2 +1,3 @@ > > obj-y += clk-mtk.o clk-pll.o clk-gate.o > > obj-$(CONFIG_RESET_CONTROLLER) += reset.o > > +obj-y += clk-mt8135.o > > diff --git a/drivers/clk/mediatek/clk-mt8135.c b/drivers/clk/mediatek/clk-mt8135.c > > new file mode 100644 > > index 0000000..6157447 > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8135.c > > @@ -0,0 +1,634 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: James Liao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +static DEFINE_SPINLOCK(lock); > > + > > > +static struct mtk_fixed_factor root_clk_alias[] __initdata = { > > Any reason you can't use "static const" here, and on all of the other > static constant structures/arrays throughout this patch. No, there is no reason. Changed it. Thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135. Date: Mon, 16 Mar 2015 06:33:18 +0100 Message-ID: <20150316053318.GC24798@pengutronix.de> References: <1424605765-19751-1-git-send-email-s.hauer@pengutronix.de> <1424605765-19751-4-git-send-email-s.hauer@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Kurtz Cc: Mike Turquette , James Liao , YH Chen , "linux-kernel@vger.kernel.org" , Henry Chen , linux-mediatek@lists.infradead.org, Sasha Hauer , Matthias Brugger , Yingjoe Chen , Eddie Huang , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org On Mon, Mar 16, 2015 at 12:27:20AM +0800, Daniel Kurtz wrote: > Hi Sascha, > > Drive-by review... > > On Sun, Feb 22, 2015 at 7:49 PM, Sascha Hauer wrote: > > From: James Liao > > > > This patch adds basic clocks for MT8135, including TOPCKGEN, PLLs, > > INFRA and PERI clocks. > > > > Signed-off-by: James Liao > > Signed-off-by: Henry Chen > > Signed-off-by: Sascha Hauer > > --- > > drivers/clk/mediatek/Makefile | 1 + > > drivers/clk/mediatek/clk-mt8135.c | 634 +++++++++++++++++++++ > > include/dt-bindings/clock/mt8135-clk.h | 190 ++++++ > > .../dt-bindings/reset-controller/mt8135-resets.h | 64 +++ > > 4 files changed, 889 insertions(+) > > create mode 100644 drivers/clk/mediatek/clk-mt8135.c > > create mode 100644 include/dt-bindings/clock/mt8135-clk.h > > create mode 100644 include/dt-bindings/reset-controller/mt8135-resets.h > > > > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > > index 0b6f1c3..12ce576 100644 > > --- a/drivers/clk/mediatek/Makefile > > +++ b/drivers/clk/mediatek/Makefile > > @@ -1,2 +1,3 @@ > > obj-y += clk-mtk.o clk-pll.o clk-gate.o > > obj-$(CONFIG_RESET_CONTROLLER) += reset.o > > +obj-y += clk-mt8135.o > > diff --git a/drivers/clk/mediatek/clk-mt8135.c b/drivers/clk/mediatek/clk-mt8135.c > > new file mode 100644 > > index 0000000..6157447 > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8135.c > > @@ -0,0 +1,634 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: James Liao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +static DEFINE_SPINLOCK(lock); > > + > > > +static struct mtk_fixed_factor root_clk_alias[] __initdata = { > > Any reason you can't use "static const" here, and on all of the other > static constant structures/arrays throughout this patch. No, there is no reason. Changed it. Thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Mon, 16 Mar 2015 06:33:18 +0100 Subject: [PATCH 3/5] clk: mediatek: Add basic clocks for Mediatek MT8135. In-Reply-To: References: <1424605765-19751-1-git-send-email-s.hauer@pengutronix.de> <1424605765-19751-4-git-send-email-s.hauer@pengutronix.de> Message-ID: <20150316053318.GC24798@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 16, 2015 at 12:27:20AM +0800, Daniel Kurtz wrote: > Hi Sascha, > > Drive-by review... > > On Sun, Feb 22, 2015 at 7:49 PM, Sascha Hauer wrote: > > From: James Liao > > > > This patch adds basic clocks for MT8135, including TOPCKGEN, PLLs, > > INFRA and PERI clocks. > > > > Signed-off-by: James Liao > > Signed-off-by: Henry Chen > > Signed-off-by: Sascha Hauer > > --- > > drivers/clk/mediatek/Makefile | 1 + > > drivers/clk/mediatek/clk-mt8135.c | 634 +++++++++++++++++++++ > > include/dt-bindings/clock/mt8135-clk.h | 190 ++++++ > > .../dt-bindings/reset-controller/mt8135-resets.h | 64 +++ > > 4 files changed, 889 insertions(+) > > create mode 100644 drivers/clk/mediatek/clk-mt8135.c > > create mode 100644 include/dt-bindings/clock/mt8135-clk.h > > create mode 100644 include/dt-bindings/reset-controller/mt8135-resets.h > > > > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > > index 0b6f1c3..12ce576 100644 > > --- a/drivers/clk/mediatek/Makefile > > +++ b/drivers/clk/mediatek/Makefile > > @@ -1,2 +1,3 @@ > > obj-y += clk-mtk.o clk-pll.o clk-gate.o > > obj-$(CONFIG_RESET_CONTROLLER) += reset.o > > +obj-y += clk-mt8135.o > > diff --git a/drivers/clk/mediatek/clk-mt8135.c b/drivers/clk/mediatek/clk-mt8135.c > > new file mode 100644 > > index 0000000..6157447 > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8135.c > > @@ -0,0 +1,634 @@ > > +/* > > + * Copyright (c) 2014 MediaTek Inc. > > + * Author: James Liao > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +static DEFINE_SPINLOCK(lock); > > + > > > +static struct mtk_fixed_factor root_clk_alias[] __initdata = { > > Any reason you can't use "static const" here, and on all of the other > static constant structures/arrays throughout this patch. No, there is no reason. Changed it. Thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |