From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXOgg-0008M5-1Y for qemu-devel@nongnu.org; Mon, 16 Mar 2015 02:39:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXOgV-0005Lx-C7 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 02:39:41 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:48153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXOgV-0005LV-1I for qemu-devel@nongnu.org; Mon, 16 Mar 2015 02:39:31 -0400 Date: Mon, 16 Mar 2015 17:18:40 +1100 From: David Gibson Message-ID: <20150316061840.GE5741@voom.redhat.com> References: <1424883128-9841-1-git-send-email-dgilbert@redhat.com> <1424883128-9841-21-git-send-email-dgilbert@redhat.com> <20150313010058.GZ11973@voom.redhat.com> <20150313101953.GA2486@work-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qjNfmADvan18RZcF" Content-Disposition: inline In-Reply-To: <20150313101953.GA2486@work-vm> Subject: Re: [Qemu-devel] [PATCH v5 20/45] Modify savevm handlers for postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com, yanghy@cn.fujitsu.com --qjNfmADvan18RZcF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 13, 2015 at 10:19:54AM +0000, Dr. David Alan Gilbert wrote: > * David Gibson (david@gibson.dropbear.id.au) wrote: > > On Wed, Feb 25, 2015 at 04:51:43PM +0000, Dr. David Alan Gilbert (git) = wrote: > > > From: "Dr. David Alan Gilbert" > > >=20 > > > Modify save_live_pending to return separate postcopiable and > > > non-postcopiable counts. > > >=20 > > > Add 'can_postcopy' to allow a device to state if it can postcopy > >=20 > > What's the purpose of the can_postcopy callback? There are no callers > > in this patch - is it still necessary with the change to > > save_live_pending? >=20 > The patch 'qemu_savevm_state_complete: Postcopy changes' uses > it in qemu_savevm_state_postcopy_complete and qemu_savevm_state_complete > to decide which devices must be completed at that point. Couldn't they check for non-zero postcopiable state from save_live_pending instead? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qjNfmADvan18RZcF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVBnXAAAoJEGw4ysog2bOSbH0QAN4Qs1a3Uj0kUdGAGXVUASIi 2aEz6mHH1kbgMhQZ/1Ia1qKxRQvIwqN8Jg9XRKP+Rt0av0kBCyFGkZKtPV1KLcGE Nklhh+phebTfPDrR1Qg3I8ZbOTm2ecJyoEcgee230nHfjxaTgoaopn6Nnf0dRu6m ZhqruVQLciSDlgNIezYLsbGZ7+nj1oSDpM9Z0g0aAthGhgZKROEgsD1Z/EZXLPO5 j588nXbJGEkPAcg9lh6mFeZBlkexh+oIKLZDlMppikXUun87WRCJqm8bBHu9S4c6 JlAKiDs1Y5vpRzczgL+e51l+JNqA29IZw7l5C2Umd931U7ScqS7pRtTbw3HKquN8 DHgqW5FeCwAIxRSb7ynPFgvzCkUjQQSs7M7He3txtI7tqoURzKargAt2ICaQ3LO6 XbSU95KUUzXTUVPhXb/DNrzC+RUZeqlzVMZDR943jIhPLRjMMGpkJEx9LQchRv/h KFeiu84umwXgagvmHUgCJh7R/t1xYiWzxVMiHauCT/pFfTGHj5RxbD4xvDNv81vr l1HTlDoZ4Xcf0rUYOq2PFcuQ2HRXq4u+hJa/JdvtEdWUHCmBhgm8RupLUCAFJW90 Xa8pPauwaGQEW+hu+Zlz6XLaeD8tOmhTjpussCaIgCMy8fw/Dp1ojmLw5/bAc2wy /RiBEm7R+pJSlGJ+MAOm =LF/P -----END PGP SIGNATURE----- --qjNfmADvan18RZcF--