From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [v1 PATCH 7/14] netfilter: Use rhashtable_lookup instead of lookup_compare Date: Mon, 16 Mar 2015 20:14:15 +1100 Message-ID: <20150316091415.GA31089@gondor.apana.org.au> References: <20150315104306.GA21999@gondor.apana.org.au> <20150316082842.GA10896@casper.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , netdev@vger.kernel.org, Eric Dumazet , kaber@trash.net To: Thomas Graf Return-path: Received: from ringil.hengli.com.au ([178.18.16.133]:47799 "EHLO ringil.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbbCPJO1 (ORCPT ); Mon, 16 Mar 2015 05:14:27 -0400 Content-Disposition: inline In-Reply-To: <20150316082842.GA10896@casper.infradead.org> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 16, 2015 at 08:28:42AM +0000, Thomas Graf wrote: > On 03/15/15 at 09:44pm, Herbert Xu wrote: > > The use of rhashtable_lookup_compare in nft_hash is gratuitous > > since the comparison function is just doing memcmp. Furthermore, > > there is cruft embedded in the comparson function that should > > instead be moved into the caller of the lookup. > > > > This patch moves that cruft over and replacces the call to > > rhashtable_lookup_compare with rhashtable_lookup. > > > > Signed-off-by: Herbert Xu > > The reason for the indirection was to not bypass the abstraction > nft_data_cmp() provides. > > No objection to the change but maybe leave a comment in > nft_data_cmp() that if one changes nft_data_cmp() one needs to > look at nft_hash and see if the direct use of rhashtable_lookup() > is still valid. Well we could preserve nft_data_cmp if necessary. It'll just mean an extra indirect call to do the compare when needed. Patrick? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt