From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 8354230435840 X-Google-Groups: outreachy-kernel X-Google-Thread: 9ca63f596c,4a466ff2e2b78213 X-Google-Attributes: gid9ca63f596c,domainid0,private,googlegroup X-Google-NewGroupId: yes X-Received: by 10.236.11.196 with SMTP id 44mr64348869yhx.31.1426517277712; Mon, 16 Mar 2015 07:47:57 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.95.227 with SMTP id i90ls2645733qge.59.gmail; Mon, 16 Mar 2015 07:47:57 -0700 (PDT) X-Received: by 10.236.15.38 with SMTP id e26mr12194617yhe.3.1426517277564; Mon, 16 Mar 2015 07:47:57 -0700 (PDT) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id gu4si1963936pac.1.2015.03.16.07.47.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2015 07:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mail=gregkh@linuxfoundation.org Received: from localhost (samsung-greg.wifi.rsr.lip6.fr [132.227.77.84]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id ABEE6A78; Mon, 16 Mar 2015 14:47:56 +0000 (UTC) Date: Mon, 16 Mar 2015 15:47:36 +0100 From: Greg KH To: Haneen Mohammed Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8712: replace memcpy with ether_addr_copy Message-ID: <20150316144736.GB24906@kroah.com> References: <1426339024-11656-1-git-send-email-hamohammed.sa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426339024-11656-1-git-send-email-hamohammed.sa@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) On Sat, Mar 14, 2015 at 04:17:04PM +0300, Haneen Mohammed wrote: > This patch replace memcpy with ethe_addr_copy to address the following > warning generated by checkpatch.pl: ""Prefer ether_addr_copy over memcpy > if the Ethernet addresses are __aligned(2)" > > Follwoing is the output of pahole for the relevant datastructures: > 1- for "iwe.u.ap_addr.sa_data" and "wrqu->ap_addr.sa_data" > > struct sockaddr { > sa_family_t sa_family; /* 0 2 > */ > char sa_data[14]; /* 2 14 > */ Your lines are wrapped here very oddly. Please fix that up and resend. thanks, greg k-h