From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934434AbbCPPgV (ORCPT ); Mon, 16 Mar 2015 11:36:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59071 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932778AbbCPPgR (ORCPT ); Mon, 16 Mar 2015 11:36:17 -0400 Date: Mon, 16 Mar 2015 16:36:13 +0100 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] staging: unisys: dev_t initialization Message-ID: <20150316153613.GC12503@kroah.com> References: <1426181412-19112-1-git-send-email-sudipm.mukherjee@gmail.com> <1426181412-19112-2-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426181412-19112-2-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 11:00:10PM +0530, Sudip Mukherjee wrote: > dev_t is defined to be of unsigned int type, no use initializing > it to -1. > > Signed-off-by: Sudip Mukherjee > --- > v2: it was not in v1 > > drivers/staging/unisys/visorchipset/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c > index 9ca7f1e..e9459af 100644 > --- a/drivers/staging/unisys/visorchipset/file.c > +++ b/drivers/staging/unisys/visorchipset/file.c > @@ -30,7 +30,7 @@ > > static struct cdev file_cdev; > static struct visorchannel **file_controlvm_channel; > -static dev_t majordev = -1; /**< indicates major num for device */ > +static dev_t majordev; /**< indicates major num for device */ I don't like this, please fix this up to handle the major number properly, no need for this -1 mess. And you just broke the logic with this change, which isn't allowed in any patch, sorry. greg k-h