Re: [patch net-next] switchdev: call bridge setlink/dellink ndos recursively

[Jiri Pirko <jiri@resnulli.us>]

Mon, Mar 16, 2015 at 04:21:03PM CET, roopa@cumulusnetworks.com wrote:
>On 3/16/15, 7:22 AM, Jiri Pirko wrote:
>>There has been a discussion about if it's better to let masters to
>>propagate call down themself or if its better just blindly go down and
>>try to call ndo on every lower netdev. Turned out that more people (me
>>not included) like the second option better.
>>
>>This patch changes bridge setlink/dellink in that direction.
>>Sorry Roopa for forcing you to do it the way I liked initially.
>>
>>Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>
>no worries. thanks for submitting the patch Jiri.
>
>One thing though (Which i also mentioned in one of the threads on this),
>the below command will not work with layered devices with the below patch.
>Because 'self' commands will directly try to find the switch port driver from
>rtnetlink.c and they dont use the switch dev api.
>
>bridge link set dev bond0 learning off self
>
>
>The code that currently exists in the tree with bond and team supporting the
>op
>will actually work.

Hmm, interesting.

DaveM, this might be a good argument for call propagation. What do you
think?


>
>If you agree with the above, I can rethink how this can be made to work with
>the 'self'
>indirection from rtnetlink.c and still use transparent lowerdev traversal and
>resubmit.
>Or if you prefer to resubmit, you can.
>
>Thanks,
>Roopa
>