From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933561AbbCPSSd (ORCPT ); Mon, 16 Mar 2015 14:18:33 -0400 Received: from mail.skyhub.de ([78.46.96.112]:60828 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbbCPSSb (ORCPT ); Mon, 16 Mar 2015 14:18:31 -0400 Date: Mon, 16 Mar 2015 19:16:58 +0100 From: Borislav Petkov To: Arjun Sreedharan Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86,boot: standardize strcmp() Message-ID: <20150316181658.GB22841@pd.tnic> References: <1426520267-1803-1-git-send-email-arjun024@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426520267-1803-1-git-send-email-arjun024@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 09:07:47PM +0530, Arjun Sreedharan wrote: > strcmp() is always expected to return 0 when args are > same, <0 when arg1 is lesser and >0 otherwise. > Previously strcmp("a","b") returned 1. Now it gives -1. > > Signed-off-by: Arjun Sreedharan > --- > arch/x86/boot/string.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c > index 493f3fd..318b846 100644 > --- a/arch/x86/boot/string.c > +++ b/arch/x86/boot/string.c > @@ -30,7 +30,7 @@ int strcmp(const char *str1, const char *str2) > int delta = 0; > > while (*s1 || *s2) { > - delta = *s2 - *s1; > + delta = *s1 - *s2; > if (delta) > return delta; > s1++; > -- Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --