On Tue, Mar 17, 2015 at 11:13:02AM +0200, Laurent Pinchart wrote: > Hi Wolfram, > > Thank you for the patch. > > On Tuesday 17 March 2015 08:15:23 Wolfram Sang wrote: > > From: Wolfram Sang > > > > Signed-off-by: Wolfram Sang > > --- > > > > Changes since RFC V1: rebased, added the sound-codec entry, fixed a typo > > > > arch/arm/boot/dts/r8a7790-lager.dts | 66 ++++++++++++++++++++++++---------- > > 1 file changed, 46 insertions(+), 20 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > b/arch/arm/boot/dts/r8a7790-lager.dts index 0c3b6783b72add..bf0065d676428d > > 100644 > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > @@ -222,6 +222,40 @@ > > }; > > }; > > }; > > + > > + i2c-demux { > > + > > + compatible = "i2c-demux-pinctrl"; > > + i2c-parent = <&iic2>, <&i2c2>; > > Purely from a DT point of view, wouldn't it make sense to call the node i2c- > bus and rename the i2c-parent property to i2c-masters ? I'd think so. I chose "i2c-parent" to be consistent with the existing i2c-pinctrl-mux driver. But I don't think we need to uphold this.