From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YXquC-0006iz-Bk for mharc-grub-devel@gnu.org; Tue, 17 Mar 2015 08:47:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXquA-0006iI-JX for grub-devel@gnu.org; Tue, 17 Mar 2015 08:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXqu7-0004mG-TZ for grub-devel@gnu.org; Tue, 17 Mar 2015 08:47:30 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXqu7-0004m4-NI for grub-devel@gnu.org; Tue, 17 Mar 2015 08:47:27 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t2HClFqX024603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Mar 2015 12:47:15 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t2HClDVr003021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 17 Mar 2015 12:47:14 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t2HClDBV001744; Tue, 17 Mar 2015 12:47:13 GMT Received: from olila.local.net-space.pl (/10.175.234.78) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 17 Mar 2015 05:47:12 -0700 Date: Tue, 17 Mar 2015 13:47:01 +0100 From: Daniel Kiper To: Jan Beulich Subject: Re: [PATCH 18/18] x86: add multiboot2 protocol support for EFI platforms Message-ID: <20150317124701.GZ27971@olila.local.net-space.pl> References: <1422640462-28103-1-git-send-email-daniel.kiper@oracle.com> <1422640462-28103-19-git-send-email-daniel.kiper@oracle.com> <550810B1020000780006AA3A@mail.emea.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550810B1020000780006AA3A@mail.emea.novell.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 141.146.126.69 Cc: Juergen Gross , grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2015 12:47:31 -0000 On Tue, Mar 17, 2015 at 10:32:01AM +0000, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > @@ -94,6 +111,17 @@ ENTRY(start) > > gdt_boot_descr: > > .word 6*8-1 > > .long sym_phys(trampoline_gdt) > > + .long 0 /* Needed for 64-bit lgdt */ > > + > > +cs32_switch_addr: > > + .long sym_phys(cs32_switch) > > + .long BOOT_CS32 > > + > > +efi_st: > > + .quad 0 > > + > > +efi_ih: > > + .quad 0 > > > > .Lbad_cpu_msg: .asciz "ERR: Not a 64-bit CPU!" > > .Lbad_ldr_msg: .asciz "ERR: Not a Multiboot bootloader!" > > @@ -124,6 +152,133 @@ print_err: > > .Lhalt: hlt > > jmp .Lhalt > > > > + .code64 > > + > > +__efi64_start: > > + cld > > + > > + /* Bootloaders may set multiboot[12].mem_lower to a nonzero value */ > > + xor %edx,%edx > > + > > + /* Check for Multiboot2 bootloader */ > > + cmp $MULTIBOOT2_BOOTLOADER_MAGIC,%eax > > + je efi_multiboot2_proto > > + > > + jmp not_multiboot > > + > > +efi_multiboot2_proto: > > jne not_multiboot (and efi_multiboot2_proto dropped altogether) [...] Jan, thanks for your comments. Now I am working on relocatable early Xen code. I hope that I will finish that this week and start tests on this crazy UEFI platforms. Then I get back to this patch series and replay for your and other guys comments. Daniel