All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alasdair G Kergon <agk@redhat.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: wad@chromium.org, msb@chromium.org, mpatocka@redhat.com,
	dm-devel@redhat.com
Subject: Re: [PATCHv2] dm-verity: Add error handling modes for	corrupted blocks
Date: Tue, 17 Mar 2015 18:50:53 +0000	[thread overview]
Message-ID: <20150317185053.GC21831@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20150317163707.GA39776@google.com>

On Tue, Mar 17, 2015 at 04:37:07PM +0000, Sami Tolvanen wrote:
> +<mode>
> +    Optional. 

The format needs to remain easily extendable.

Two alternatives:

  Document this as a required field going forward, but say that if
  it is missing the default will be assumed.

  eio|logging|restart  (but those names are confusing)


Or (my preference) use a 'features' approach like most other targets do:

<number of feature> <feature arguments>

"error" is the existing default, so doesn't need stating.

The other two could be:
  restart_on_corruption
  ignore_corruption

Logging and events would happen in all cases, but if they did need
controlling independently, additional feature arguments could do that.

Alasdair

  reply	other threads:[~2015-03-17 18:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 15:55 [PATCH] dm-verity: Add error handling modes for corrupted blocks Sami Tolvanen
2015-03-16 22:13 ` Will Drewry
2015-03-17  0:45   ` Alasdair G Kergon
2015-03-17 10:35     ` Sami Tolvanen
2015-03-17 10:23   ` Sami Tolvanen
2015-03-17  0:37 ` Alasdair G Kergon
2015-03-17 10:36   ` Sami Tolvanen
2015-03-17 15:27 ` Vivek Goyal
2015-03-17 16:06   ` Sami Tolvanen
2015-03-17 18:03     ` Vivek Goyal
2015-03-18 13:24       ` Sami Tolvanen
2015-03-18 15:42         ` Mikulas Patocka
2015-03-18 15:49           ` Sami Tolvanen
2015-03-17 16:37 ` [PATCHv2] " Sami Tolvanen
2015-03-17 18:50   ` Alasdair G Kergon [this message]
2015-03-18 13:26     ` Sami Tolvanen
2015-03-18 15:52 ` [PATCHv3] " Sami Tolvanen
2015-03-19 22:18   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317185053.GC21831@agk-dp.fab.redhat.com \
    --to=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=msb@chromium.org \
    --cc=samitolvanen@google.com \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.