From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932092AbbCSQ1n (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 12:27:43 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:47873 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752542AbbCSQ1k convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 12:27:40 -0400
Date: Thu, 19 Mar 2015 12:27:38 -0400 (EDT)
Message-Id: <20150319.122738.693681731967137389.davem@davemloft.net>
To: bjorn@mork.no
Cc: linux@rainbow-software.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "net: cx82310_eth: use common match macro"
From: David Miller <davem@davemloft.net>
In-Reply-To: <87y4mtcs8l.fsf@nemi.mork.no>
References: <1426716061-20953-1-git-send-email-linux@rainbow-software.org>
	<87y4mtcs8l.fsf@nemi.mork.no>
X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Bjørn Mork <bjorn@mork.no>
Date: Thu, 19 Mar 2015 09:21:30 +0100

> Ondrej Zary <linux@rainbow-software.org> writes:
> 
>> This reverts commit 11ad714b98f6d9ca0067568442afe3e70eb94845 because
>> it breaks cx82310_eth.
>>
>> The custom USB_DEVICE_CLASS macro matches
>> bDeviceClass, bDeviceSubClass and bDeviceProtocol
>> but the common USB_DEVICE_AND_INTERFACE_INFO matches
>> bInterfaceClass, bInterfaceSubClass and bInterfaceProtocol instead, which are
>> not specified.
> 
> Ouch.  What ever made me do that? Thanks a lot for fixing it!
> 
> This bug was introduced as long ago as v3.7, so the fix should go into
> every currently maintained stable branch since that.

Queued up for -stable, thanks.