From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2] libxl/libxl_qmp.c: fix qmp_open
Date: Thu, 19 Mar 2015 10:03:14 +0000
Message-ID: <20150319100314.GB16267@zion.uk.xensource.com>
References: <1426500338-36798-1-git-send-email-pramod.devendra@citrix.com>
	<1426747230-30579-1-git-send-email-pramod.devendra@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <wei.liu2@citrix.com>) id 1YYXIP-0006dh-81
	for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 10:03:21 +0000
Content-Disposition: inline
In-Reply-To: <1426747230-30579-1-git-send-email-pramod.devendra@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: PRAMOD DEVENDRA <pramod.devendra@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, Mar 19, 2015 at 06:40:30AM +0000, PRAMOD DEVENDRA wrote:
> From: Pramod Devendra <pramod.devendra@citrix.com>
> 
> Signed-off-by: Pramod Devendra <pramod.devendra@citrix.com>
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
> Changed since v1:
> 1. Make sure sun_path does not overflow.
> 2. Close qmp_fd on error.

These lines should be in the commit log itself. Putting them here makes
them get discarded when committing.

You also need to write about your third change, which was requested by
Ian. That is 

  3. Use "goto out" error handling idiom.

Wei.