From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYWh4-0008MV-Te for qemu-devel@nongnu.org; Thu, 19 Mar 2015 05:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYWh0-0003v5-T9 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 05:24:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYWh0-0003ut-Op for qemu-devel@nongnu.org; Thu, 19 Mar 2015 05:24:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 662878E66B for ; Thu, 19 Mar 2015 09:24:42 +0000 (UTC) Date: Thu, 19 Mar 2015 10:24:39 +0100 From: "Michael S. Tsirkin" Message-ID: <20150319102317-mutt-send-email-mst@redhat.com> References: <1426687214-31206-1-git-send-email-kraxel@redhat.com> <1426687214-31206-3-git-send-email-kraxel@redhat.com> <20150318152735-mutt-send-email-mst@redhat.com> <1426692713.330.15.camel@nilsson.home.kraxel.org> <20150318174504-mutt-send-email-mst@redhat.com> <1426751129.18873.16.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426751129.18873.16.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Mar 19, 2015 at 08:45:29AM +0100, Gerd Hoffmann wrote: > Hi, > > > > > if yes we'll eventually want to take > > > > the header from there. > > > > > > Yes, we can do that, for both linux input layer and virtio-input (once > > > merged upstream) headers, then go build this on non-linux hosts too. > > > > > > I'd suggest to do that as incremental patch, after guest driver merge. > > > > Hmm but why? It's just code churn. > > Adding not-yet upstream files to the list of headers to sync over from > linux isn't sane IMHO. > > cheers, > Gerd > Of course it isn't. But you can sync it manually. Once it's upstream, add it to list for automated sync. Copy-pasting some defs from there in an unrelated header seems worse. -- MST