Re: [PATCH 3/5] libxl: use new QEMU xenstore protocol

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Mar 19, 2015 at 10:55:51AM +0000, Ian Campbell wrote:
[...]
> > > > -    return GCSPRINTF("/local/domain/0/device-model/%d/physmap/%s/%s",
> > > > -            domid, phys_offset, node);
> > > > +    return GCSPRINTF("/local/domain/%d/device-model/%d/physmap/%s/%s",
> > > > +                     dm_domid, domid, phys_offset, node);
> > > 
> > > This sort of thing might imply that the helper takes the tail of the
> > > path?
> > 
> > What do you mean? Sorry I don't follow.
> 
> I suggested before having a helper to return
> "/local/domain/0/device-model/%d/", this hunk made me wonder if perhaps
> that helper should take a "const char *fmt, ..." which it appends, so
> you would call it as:
> 
>      foo(dm_domid, domid, "physmap/%s/%s", phys_offset, node)
> 
> or if you just want the base path for some reason
>      foo(dm_domid, domid, "") (or NULL as the last parameter).
> 

OK. I get your idea.

> (I'm unclear if dm_domid and domid are both needed or if the funcution
> can call get_stubdom_id(domid) internally, I'm sure you know...).
> 

dm_domid is still needed.

Wei.