From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755824AbbCSPLa (ORCPT ); Thu, 19 Mar 2015 11:11:30 -0400 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:44502 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751529AbbCSPL1 (ORCPT ); Thu, 19 Mar 2015 11:11:27 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2194:2199:2380:2393:2553:2559:2562:2901:3138:3139:3140:3141:3142:3353:3622:3867:3870:3871:4250:4321:4605:5007:6119:6120:6261:6742:7875:7901:7903:8603:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12555:12740:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: rake42_80d93729ec659 X-Filterd-Recvd-Size: 3399 Date: Thu, 19 Mar 2015 11:11:24 -0400 From: Steven Rostedt To: Alexei Starovoitov Cc: Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , "David S. Miller" , Daniel Borkmann , Peter Zijlstra , linux-api@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 tip 3/8] tracing: allow BPF programs to call bpf_ktime_get_ns() Message-ID: <20150319111124.38f53061@gandalf.local.home> In-Reply-To: <1426542584-9406-4-git-send-email-ast@plumgrid.com> References: <1426542584-9406-1-git-send-email-ast@plumgrid.com> <1426542584-9406-4-git-send-email-ast@plumgrid.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Mar 2015 14:49:39 -0700 Alexei Starovoitov wrote: > bpf_ktime_get_ns() is used by programs to compue time delta between events "compute" > or as a timestamp > > Signed-off-by: Alexei Starovoitov > --- > include/uapi/linux/bpf.h | 1 + > kernel/trace/bpf_trace.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 4486d36d2e9e..101e509d1001 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -165,6 +165,7 @@ enum bpf_func_id { > BPF_FUNC_map_update_elem, /* int map_update_elem(&map, &key, &value, flags) */ > BPF_FUNC_map_delete_elem, /* int map_delete_elem(&map, &key) */ > BPF_FUNC_probe_read, /* int bpf_probe_read(void *dst, int size, void *src) */ > + BPF_FUNC_ktime_get_ns, /* u64 bpf_ktime_get_ns(void) */ > __BPF_FUNC_MAX_ID, > }; > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index ba95b131082c..74eb6abda6a1 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -56,6 +56,12 @@ static u64 bpf_probe_read(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > return probe_kernel_read(dst, unsafe_ptr, size); > } > > +static u64 bpf_ktime_get_ns(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > +{ > + /* NMI safe access to clock monotonic */ > + return ktime_get_mono_fast_ns(); > +} > + > static struct bpf_func_proto kprobe_prog_funcs[] = { > [BPF_FUNC_probe_read] = { > .func = bpf_probe_read, > @@ -65,6 +71,11 @@ static struct bpf_func_proto kprobe_prog_funcs[] = { > .arg2_type = ARG_CONST_STACK_SIZE, > .arg3_type = ARG_ANYTHING, > }, > + [BPF_FUNC_ktime_get_ns] = { > + .func = bpf_ktime_get_ns, > + .gpl_only = true, > + .ret_type = RET_INTEGER, Hmm, a nanosecond value returned as integer? Is there a way to make this a 64 bit return type, or is RET_INTEGER default to 64 bits in BPF functions? -- Steve > + }, > }; > > static const struct bpf_func_proto *kprobe_prog_func_proto(enum bpf_func_id func_id) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH v7 tip 3/8] tracing: allow BPF programs to call bpf_ktime_get_ns() Date: Thu, 19 Mar 2015 11:11:24 -0400 Message-ID: <20150319111124.38f53061@gandalf.local.home> References: <1426542584-9406-1-git-send-email-ast@plumgrid.com> <1426542584-9406-4-git-send-email-ast@plumgrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , "David S. Miller" , Daniel Borkmann , Peter Zijlstra , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexei Starovoitov Return-path: In-Reply-To: <1426542584-9406-4-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, 16 Mar 2015 14:49:39 -0700 Alexei Starovoitov wrote: > bpf_ktime_get_ns() is used by programs to compue time delta between events "compute" > or as a timestamp > > Signed-off-by: Alexei Starovoitov > --- > include/uapi/linux/bpf.h | 1 + > kernel/trace/bpf_trace.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 4486d36d2e9e..101e509d1001 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -165,6 +165,7 @@ enum bpf_func_id { > BPF_FUNC_map_update_elem, /* int map_update_elem(&map, &key, &value, flags) */ > BPF_FUNC_map_delete_elem, /* int map_delete_elem(&map, &key) */ > BPF_FUNC_probe_read, /* int bpf_probe_read(void *dst, int size, void *src) */ > + BPF_FUNC_ktime_get_ns, /* u64 bpf_ktime_get_ns(void) */ > __BPF_FUNC_MAX_ID, > }; > > diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c > index ba95b131082c..74eb6abda6a1 100644 > --- a/kernel/trace/bpf_trace.c > +++ b/kernel/trace/bpf_trace.c > @@ -56,6 +56,12 @@ static u64 bpf_probe_read(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > return probe_kernel_read(dst, unsafe_ptr, size); > } > > +static u64 bpf_ktime_get_ns(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > +{ > + /* NMI safe access to clock monotonic */ > + return ktime_get_mono_fast_ns(); > +} > + > static struct bpf_func_proto kprobe_prog_funcs[] = { > [BPF_FUNC_probe_read] = { > .func = bpf_probe_read, > @@ -65,6 +71,11 @@ static struct bpf_func_proto kprobe_prog_funcs[] = { > .arg2_type = ARG_CONST_STACK_SIZE, > .arg3_type = ARG_ANYTHING, > }, > + [BPF_FUNC_ktime_get_ns] = { > + .func = bpf_ktime_get_ns, > + .gpl_only = true, > + .ret_type = RET_INTEGER, Hmm, a nanosecond value returned as integer? Is there a way to make this a 64 bit return type, or is RET_INTEGER default to 64 bits in BPF functions? -- Steve > + }, > }; > > static const struct bpf_func_proto *kprobe_prog_func_proto(enum bpf_func_id func_id)