From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751867AbbCSLod (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Mar 2015 07:44:33 -0400
Received: from mga01.intel.com ([192.55.52.88]:6555 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751157AbbCSLoa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Mar 2015 07:44:30 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,429,1422950400"; 
   d="scan'208";a="667485751"
Date: Thu, 19 Mar 2015 13:44:25 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Felipe Balbi <balbi@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        David Cohen <david.a.cohen@linux.intel.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Baolu Lu <baolu.lu@linux.intel.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 01/12] usb: add bus type for USB ULPI
Message-ID: <20150319114425.GA2435@kuha.fi.intel.com>
References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com>
 <1426682433-133813-2-git-send-email-heikki.krogerus@linux.intel.com>
 <1426721195.2375.10.camel@x220>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426721195.2375.10.camel@x220>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +#include <linux/module.h>
> 
> So is this include needed?

I can change it to linux/kmod.h. We'll still do the request_module
call even after these changes.

> > +static int __init ulpi_init(void)
> > +{
> > +	return bus_register(&ulpi_bus);
> > +}
> > +module_init(ulpi_init);
> 
> This will be equivalent to
>     __initcall(ulpi_init)
> 
> according to include/linux/init.h.

I'll change it to subsys_initcall(ulpi_init).

> > +static void __exit ulpi_exit(void)
> > +{
> > +	bus_unregister(&ulpi_bus);
> > +}
> > +module_exit(ulpi_exit);
> 
> This will never be called.
> 
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("USB ULPI PHY bus");
> 
> And these three macros will be, effectively, preprocessed away.

True. I'll drop them.


Thanks,

-- 
heikki