From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283AbbCSLv2 (ORCPT ); Thu, 19 Mar 2015 07:51:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:50536 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbbCSLvZ (ORCPT ); Thu, 19 Mar 2015 07:51:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,429,1422950400"; d="scan'208";a="469461651" Date: Thu, 19 Mar 2015 13:51:20 +0200 From: Heikki Krogerus To: David Cohen Cc: Felipe Balbi , Greg Kroah-Hartman , Stephen Boyd , Baolu Lu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails Message-ID: <20150319115120.GC2435@kuha.fi.intel.com> References: <1426682433-133813-1-git-send-email-heikki.krogerus@linux.intel.com> <1426682433-133813-10-git-send-email-heikki.krogerus@linux.intel.com> <20150318170855.GB25477@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150318170855.GB25477@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > @@ -65,6 +76,31 @@ static int dwc3_pci_quirks(struct pci_dev *pdev) > > sizeof(pdata)); > > } > > > > + if (pdev->vendor == PCI_VENDOR_ID_INTEL && > > + pdev->device == PCI_DEVICE_ID_INTEL_BYT) { > > + struct gpio_desc *gpio; > > + > > + acpi_dev_add_driver_gpios(ACPI_COMPANION(&pdev->dev), > > + acpi_dwc3_byt_gpios); > > + > > + gpio = gpiod_get(&pdev->dev, "reset"); > > + if (IS_ERR(gpio)) > > + return 0; > > + > > + /* These GPIOs will turn on the USB2 PHY */ > > + gpiod_direction_output(gpio, 0); > > + gpiod_set_value_cansleep(gpio, 1); > > + gpiod_put(gpio); > > + > > + gpio = gpiod_get(&pdev->dev, "cs"); > > CS GPIO should be handled before RESET. OK, I'll fix it. Thanks, -- heikki