From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Deepak S <deepak.s@linux.intel.com>,
intel-gfx@lists.freedesktop.org, "Satyanantha,
Rama Gopal M" <rama.gopal.m.satyanantha@intel.com>,
Damien Lespiau <damien.lespiau@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2] drm/i915: Fallback to using unmappable memory for scanout
Date: Thu, 19 Mar 2015 17:34:09 +0100 [thread overview]
Message-ID: <20150319163409.GC31422@phenom.ffwll.local> (raw)
In-Reply-To: <20150319131013.GL10812@nuc-i3427.alporthouse.com>
On Thu, Mar 19, 2015 at 01:10:13PM +0000, Chris Wilson wrote:
> On Thu, Mar 19, 2015 at 06:31:04PM +0530, Deepak S wrote:
> > should we skip put_fence in overlay_do_put_image ?
>
> Ah interesting point you raise there. That is buggy code fullstop.
> We should not be call put_fence if pin_to_display_plane pins the fence.
> Techinically the overlay could use a fence, the restriction is more to
> do with an artificial limitation on the overlay API, and so the actual
> call to i915_gem_object_put_fence() can be removed without any ill
> side-effects. Something for the next time someone considers gen2-4 code.
The put_fence in there is iirc to synchronize with the lazy tiling, just
in case. Or at least that's the story I remember.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-19 16:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 22:08 [PATCH] drm/i915: Fallback to using unmappable memory for scanout Chris Wilson
2015-03-19 10:53 ` Deepak S
2015-03-19 11:27 ` Chris Wilson
2015-03-19 11:29 ` [PATCH v2] " Chris Wilson
2015-03-19 13:01 ` Deepak S
2015-03-19 13:10 ` Chris Wilson
2015-03-19 13:13 ` Deepak S
2015-03-19 16:34 ` Daniel Vetter [this message]
2015-03-19 16:51 ` Chris Wilson
2015-03-19 16:35 ` Daniel Vetter
2015-03-19 16:50 ` Chris Wilson
2015-03-20 10:29 ` Daniel Vetter
2015-03-20 10:49 ` Chris Wilson
2015-03-20 14:36 ` Daniel Vetter
2015-03-20 14:52 ` Ville Syrjälä
2015-03-19 16:39 ` Damien Lespiau
2015-03-19 16:54 ` Chris Wilson
2015-03-19 21:57 ` shuang.he
2015-03-25 12:21 ` Jani Nikula
2015-03-25 12:40 ` [PATCH v3] " Chris Wilson
2015-03-25 15:07 ` shuang.he
2015-03-25 12:44 ` [PATCH v4] " Chris Wilson
2015-03-25 13:17 ` Daniel Vetter
2015-03-25 17:30 ` shuang.he
2015-03-19 15:34 ` [PATCH] " shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319163409.GC31422@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rama.gopal.m.satyanantha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.