From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751151AbbCTG0K (ORCPT ); Fri, 20 Mar 2015 02:26:10 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38739 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbbCTG0I (ORCPT ); Fri, 20 Mar 2015 02:26:08 -0400 Date: Fri, 20 Mar 2015 07:26:03 +0100 From: Richard Cochran To: Baolin Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, John Stultz , tglx@linutronix.de, Arnd Bergmann Subject: Re: [PATCH 2/4] ptp/clcok:Introduce the setktime/getktime interfaces with "ktime_t" type Message-ID: <20150320062603.GC4417@localhost.localdomain> References: <1426743909-24335-1-git-send-email-baolin.wang@linaro.org> <1426743909-24335-3-git-send-email-baolin.wang@linaro.org> <20150319075416.GB4568@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2015 at 09:54:05AM +0800, Baolin Wang wrote: > Next patch series will contain all of the drivers which need to be changed. > But i think the conditional in ptp_clock.c can still in there. Why? > Because our plan is once all the drivers are converted, i will remove the > conditional, along with the original function pointer. > Is that OK? Thanks! I want to avoid a patch series that introduces something, only to remove it later on. Sometimes you have to do that way for a complex transformation, but this case is rather simple. You can change the gettime signature in one patch, and the settime in a second patch. Thanks, Richard