From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Date: Fri, 20 Mar 2015 07:24:41 +0000 Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Message-Id: <20150320072441.GA10068@pengutronix.de> List-Id: References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> <20150319201751.GZ10068@pengutronix.de> <20150320071504.GA906@katana> In-Reply-To: <20150320071504.GA906@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Moin Wolfram, On Fri, Mar 20, 2015 at 08:15:04AM +0100, Wolfram Sang wrote: > On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-K=F6nig wrote: > > Hello Wolfram, > >=20 > > On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > > > From: Wolfram Sang > > >=20 > > > After more discussion, brave users, and additional datasheet evaluati= on, > > > some API updates for the new I2C slave framework became imminent. The > > > slave events now get some easier to understand naming. Also, the event > > > handling has been simplified to only send one event per interrupt. > > what is an interrupt here? An event where the bus driver needs feedback > > from the backend? >=20 > More the other way around: when the bus driver needs to notify the > backend. I wasn't 100% sure about the word 'interrupt', but then decided > a HW slave support without interrupts would be so rare and adventurous > that it is okay to use the term :) Yeah, I agree on HW slave support without interrupts is hardly possible. But I imagine that controllers differ in which situations they can issue an interrupt so talking about them for generic code feels strange to me because $flexiblecontrolerwithvariousirqs doesn't need to send more events than $bareminimumcontroler. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbbCTH2H (ORCPT ); Fri, 20 Mar 2015 03:28:07 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51061 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbbCTH2E (ORCPT ); Fri, 20 Mar 2015 03:28:04 -0400 Date: Fri, 20 Mar 2015 08:24:41 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Message-ID: <20150320072441.GA10068@pengutronix.de> References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> <20150319201751.GZ10068@pengutronix.de> <20150320071504.GA906@katana> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150320071504.GA906@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moin Wolfram, On Fri, Mar 20, 2015 at 08:15:04AM +0100, Wolfram Sang wrote: > On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-König wrote: > > Hello Wolfram, > > > > On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > > > From: Wolfram Sang > > > > > > After more discussion, brave users, and additional datasheet evaluation, > > > some API updates for the new I2C slave framework became imminent. The > > > slave events now get some easier to understand naming. Also, the event > > > handling has been simplified to only send one event per interrupt. > > what is an interrupt here? An event where the bus driver needs feedback > > from the backend? > > More the other way around: when the bus driver needs to notify the > backend. I wasn't 100% sure about the word 'interrupt', but then decided > a HW slave support without interrupts would be so rare and adventurous > that it is okay to use the term :) Yeah, I agree on HW slave support without interrupts is hardly possible. But I imagine that controllers differ in which situations they can issue an interrupt so talking about them for generic code feels strange to me because $flexiblecontrolerwithvariousirqs doesn't need to send more events than $bareminimumcontroler. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Date: Fri, 20 Mar 2015 08:24:41 +0100 Message-ID: <20150320072441.GA10068@pengutronix.de> References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> <20150319201751.GZ10068@pengutronix.de> <20150320071504.GA906@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150320071504.GA906@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Moin Wolfram, On Fri, Mar 20, 2015 at 08:15:04AM +0100, Wolfram Sang wrote: > On Thu, Mar 19, 2015 at 09:17:51PM +0100, Uwe Kleine-K=F6nig wrote: > > Hello Wolfram, > >=20 > > On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > > > From: Wolfram Sang > > >=20 > > > After more discussion, brave users, and additional datasheet eval= uation, > > > some API updates for the new I2C slave framework became imminent.= The > > > slave events now get some easier to understand naming. Also, the = event > > > handling has been simplified to only send one event per interrupt= =2E > > what is an interrupt here? An event where the bus driver needs feed= back > > from the backend? >=20 > More the other way around: when the bus driver needs to notify the > backend. I wasn't 100% sure about the word 'interrupt', but then deci= ded > a HW slave support without interrupts would be so rare and adventurou= s > that it is okay to use the term :) Yeah, I agree on HW slave support without interrupts is hardly possible= =2E But I imagine that controllers differ in which situations they can issu= e an interrupt so talking about them for generic code feels strange to me because $flexiblecontrolerwithvariousirqs doesn't need to send more events than $bareminimumcontroler. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |