From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [v1 PATCH 7/14] netfilter: Use rhashtable_lookup instead of lookup_compare Date: Fri, 20 Mar 2015 09:22:17 +0000 Message-ID: <20150320092216.GE21258@acer.localdomain> References: <20150315104306.GA21999@gondor.apana.org.au> <20150316082842.GA10896@casper.infradead.org> <20150316091415.GA31089@gondor.apana.org.au> <20150316111345.GA22070@acer.localdomain> <20150320085509.GA16748@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Graf , David Miller , netdev@vger.kernel.org, Eric Dumazet To: Herbert Xu Return-path: Received: from stinky.trash.net ([213.144.137.162]:34897 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbbCTJWW (ORCPT ); Fri, 20 Mar 2015 05:22:22 -0400 Content-Disposition: inline In-Reply-To: <20150320085509.GA16748@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: On 20.03, Herbert Xu wrote: > On Mon, Mar 16, 2015 at 11:13:46AM +0000, Patrick McHardy wrote: > > > > An upcoming patchset will add transaction support to sets, which needs > > the callback. So please leave it for know since it will only cause > > unnecessary churn. > > Patrick, can you explain what you mean by the callback? I need the compare functions for transaction support to decide whether an element is already activated or has been deactivated and, with a further patch, for timeouts. Inactive and timed out elements are treated as non-existant but are in case of transactions present in the hash until the transaction is committed, in case of timeouts until GC.